Simplify CMake Builds #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncs the build.yml workflow with the latest changes from the main branch. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Split workflow into separate debug and release jobs for parallel builds - Use CMake presets instead of manual generator flags - Update artifact paths to use bin/ directory structure - Include test executables (KernelTestHost for Debug) - Remove unnecessary generator flag (-G "Visual Studio 17 2022") Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add Detours as git submodule from https://github.com/microsoft/detours.git - Create Detours-build/CMakeLists.txt to build lib_detours static library - Update src/dll/CMakeLists.txt to link against locally built Detours - Remove dependency on vcpkg for Detours (fixes GitHub Actions build) - Initialize submodule with git submodule update --init --recursive This allows the DLL component to be built with Detours without relying on vcpkg's problematic build of the detours package. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Since Detours is now built locally as a git submodule, it's no longer needed as a vcpkg dependency. This resolves the GitHub Actions build failure related to detours compilation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add CMAKE_GENERATOR environment variable set to "Visual Studio 17 2022" - Add submodules: recursive to checkout step for Detours submodule - Ensures vcpkg uses MSBuild for building dependencies, not Ninja - Resolves issues with ninja-based vcpkg builds in CI/CD Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The CMakePresets.json already specifies 'Visual Studio 17 2022' as the generator for both debug and release presets, so the CMAKE_GENERATOR environment variable was redundant. Removing it keeps the workflow clean and ensures all configuration comes from the presets. Workflow now: - Uses cmake --preset debug and cmake --preset release - Properly initializes git submodules (for Detours) - Builds with MSBuild using the generated solutions - Uploads artifacts to GitHub Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add CMAKE_GENERATOR env variable to vcpkg setup step - Add CMAKE_GENERATOR env variable to cmake configuration steps - Ensures vcpkg builds its dependencies (zlib, grpc, etc) with MSBuild instead of Ninja, which was causing resource compiler failures The CMAKE_GENERATOR environment variable set during vcpkg step tells vcpkg which generator to use when building its own dependencies, preventing Ninja from being used and avoiding linker/RC compiler errors. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add Windows SDK tools to PATH before vcpkg runs. The resource compiler (RC.exe) was failing during vcpkg's compiler detection when building dependencies with Ninja. This step ensures RC.exe is available in the environment by adding the Windows SDK bin directory to PATH. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.