Update GitHub Actions workflow with fixes from simplify branch #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporated multiple fixes to ensure proper build in GitHub Actions: 1. **Add Windows SDK tools to PATH**: Fixes RC.exe not found error by adding Windows SDK bin directory to PATH before vcpkg runs. This ensures the Resource Compiler is available during dependency builds. 2. **Explicit generator specification**: Added `-G "Visual Studio 17 2022"` to cmake commands to ensure MSBuild is used instead of Ninja, preventing linker and resource compiler errors. 3. **vcpkg build caching**: Added `useVcpkgInstallArtifactCaching: true` to speed up builds by caching vcpkg artifacts between runs. 4. **Submodule support**: Added `submodules: recursive` to checkout step to support repositories using git submodules (like Detours). 5. **Split debug/release builds**: Separated into two parallel jobs for better build organization and potential parallelization. 6. **Updated artifact paths**: Changed artifact paths to bin/ directory to match actual build output locations. These changes address build failures related to missing build tools, incorrect generator selection, and missing dependencies.
CMakePresets.json now defines x86_BUILD_TOOLS_PATH and x64_BUILD_TOOLS_PATH variables, so the manual PATH modification is no longer needed.
Install Ninja build system using Chocolatey in both debug and release build jobs. This ensures Ninja is available for vcpkg and CMake.
Install Chocolatey package manager before installing Ninja, since Chocolatey is not pre-installed on the self-hosted runner.
Change shell from pwsh (PowerShell Core) to powershell (Windows PowerShell) for Chocolatey installation since pwsh is not available on the self-hosted runner.
- Merge Chocolatey and Ninja installation into a single step - Add administrator privilege check to ensure proper permissions - Refresh environment PATH after Chocolatey installation to make choco available - This ensures the installation runs with elevated privileges on the self-hosted runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporated multiple fixes to ensure proper build in GitHub Actions:
Add Windows SDK tools to PATH: Fixes RC.exe not found error by
adding Windows SDK bin directory to PATH before vcpkg runs. This ensures
the Resource Compiler is available during dependency builds.
Explicit generator specification: Added
-G "Visual Studio 17 2022"to cmake commands to ensure MSBuild is used instead of Ninja, preventing
linker and resource compiler errors.
vcpkg build caching: Added
useVcpkgInstallArtifactCaching: truetospeed up builds by caching vcpkg artifacts between runs.
Submodule support: Added
submodules: recursiveto checkout step tosupport repositories using git submodules (like Detours).
Split debug/release builds: Separated into two parallel jobs for
better build organization and potential parallelization.
Updated artifact paths: Changed artifact paths to bin/ directory to
match actual build output locations.
These changes address build failures related to missing build tools,
incorrect generator selection, and missing dependencies.