Detect Apama, fix up settings, use stdio LSP, miscellaneous cleanup #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bph-c8y
commented
Jan 17, 2025
•
bph-c8y
commented
- Add in a mechanism for the extension to automatically detect an Apama installation, as opposed to requiring the user to specify a directory. The user can of course override this.
- Fix up settings to be properly rendered - using CamelCase tells VSCode to separate the words.
- Use the new stdio interface for communication: requires >=10.15.6.0, but should be a much cleaner way for us to interface with the Language Server, and is the general standard.
- As a consequence of this, we no longer handle process setup and teardown: this is handled by the LSP library.
- Other miscellaneous cleanup.
Improve our ability to find Apama processes on the system.
- Default apamahome assumed Windows. - Various descriptions implied the set value was the default, which is obviously not true if it is configurable. - Remove option for a "Remote" language server: while it currently works, it will soon be removed, and is antithetical to how MS expect you to run a Language Server.
VSCode automatically parses camel case names to be separate words.
We're going to use this to gate all advanced functionality.
Also, some renaming of things to less generic names.
- Remove all networking artifacts. - Let the Language Client handle spawning the process (and thus, process cleanup). - Remove language server networking configuration options. - Remove all process cleanup code, and associated libraries.
ben-c8y
requested changes
Feb 19, 2025
Diagnostics was getting confused with the language server - excise that word, and instead refer to the advanced syntax highlighting features we're actually proposing users use. syntax highlighting features we're actually proposing users use
ben-c8y
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.