feat: add support for unverified uniswap v3 pools [APE-1616] #109
Conversation
vany365
changed the title
| if not (abi_string := source_code.abi): | ||
| return None | ||
|
|
||
| try: | ||
| abi = json.loads(abi_string) | ||
| except JSONDecodeError as err: | ||
| logger.error(f"Error with contract ABI: {err}") | ||
| return None | ||
| contract_creation = contract_client.get_creation_data() |
There was a problem hiding this comment.
thought: much of this proxy checking here could be abstracted into a helper method on this instance to avoid so much stuff happening in the except block
| if not hasattr(contract_creation[0], "txHash"): | ||
| return None | ||
|
|
||
| tx_hash = contract_creation[0].txHash |
There was a problem hiding this comment.
idea: could use walrus like you do during if not (to_address := transaction_by_hash.toAddress): below
| if not self.conversion_manager.is_type(to_address, AddressType): | ||
| to_address = self.conversion_manager.convert(str(to_address), AddressType) | ||
|
|
||
| if to_address == UNISWAP_V3_POSITIONS_NFT: |
There was a problem hiding this comment.
would like @fubuloubu 's thought here, else I will return after I have reread the description of the PR and done research...
gut feeling at first review: it this something that ape's proxy system should be handling?
There was a problem hiding this comment.
I suppose would like it that more protocol-specific handling end up in the protocol SDK libraries, so we don't end up cluttering the plugins/core a lot
But this is popular, so could be convinced
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
| return None | ||
|
|
||
| proxy_client = self._client_factory.get_proxy_client(tx_hash) | ||
| transaction_by_hash = proxy_client.get_transaction_by_hash() |
There was a problem hiding this comment.
Instead of making a new client, you could do transaction_by_hash = self.provider.ge_receipt(tx_hash)
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. |
What I did
Allowed unverified Uniswap v3 contracts that are designated as "similar code" to pull a generic Uniswap v3 ABI instead of failing.
How I did it
Created a new
Clientfor theproxyendpoint. Specifically to pass in atx_hash. I recognize there are other data pieces you would want to pass in toproxyactions, but for this use case this seemed simplest.Created a new
GetTransactionByHashResponsedataclassCreated a new
get_transaction_by_hashfunction which returnsGetTransactionByHashResponseAdjusted the
ape_etherscan/explorer/get_contract_typefunction to run a check if theabiis not properly returned by thegetsourcecodeendpoint (the response is not JSON).If it is not valid JSON, meaning it is a string saying
Contract source code not verified, get the contract creation data, which gives us the transaction hash of the contract creation.call the
proxy/eth_getTransactionByHashendpoint using the new Proxy Client and retrieve the transaction informationCheck the
tofield from the transaction against the known Uniswap V3: Positions NFT address, which is thetoaddress of all Uniswap v3 pool initializations.Load the generic Uniswap v3 ABI constant from
ape_etherscan/utilsContinue the
get_contract_typelogic.How to verify it
Load an ape console and try to get an unverified Uniswap v3 contract. Example:
contract = Contract('0x86E69D1AE728c9Cd229F07bBf34E01bF27258354')It should have no errors and the contract should be available.
Checklist