feat: allow private transaction receipts to bail out before transaction acceptance #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…confirmations that won't show
antazoey
previously approved these changes
Sep 12, 2024
…e-transaction-timeout
antazoey
changed the title
…transactions, but an early partial receipt to be returned if they time out
antazoey
reviewed
Sep 18, 2024
added 3 commits
September 18, 2024 10:41
antazoey
reviewed
Sep 19, 2024
added 2 commits
September 19, 2024 15:39
antazoey
previously approved these changes
Sep 19, 2024
antazoey
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Made it so private transactions won't time out awaiting confirmations that will never show.
fixes: ApeWorX/ape-alchemy#82
Fixes: APE-1805
How I did it
In the provider method for getting a receipt, moved around the logic to pass through transaction info to receipt data earlier so that private transactions can early return a partial receipt.
How to verify it
Add the
private=Truekwarg toprovider.get_receipt()Checklist