Skip to content

Commit

Permalink
chore(ci): run non-flaky tests again (n0-computer#1948)
Browse files Browse the repository at this point in the history
## Description

We had a bug in the github actions job that resulted in not running
any tests.  Oops.

## Notes & open questions

Running 248 tests again!

Newly marked flaky test already covered by n0-computer#1935 

## Change checklist

- [x] Self-review.
  • Loading branch information
flub authored and fubuloubu committed Feb 21, 2024
1 parent a9e01f0 commit 36a6157
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:

- name: tests
run: |
cargo nextest run --workspace ${{ env.FEATURES }} --lib --bins --tests ${{ inputs.flaky && '--run-ignored all' }}
cargo nextest run --workspace ${{ env.FEATURES }} --lib --bins --tests ${{ inputs.flaky && '--run-ignored all' || '' }}
env:
RUST_LOG: "TRACE"

Expand Down Expand Up @@ -172,6 +172,6 @@ jobs:

- name: tests
run: |
cargo nextest run --workspace ${{ env.FEATURES }} --lib --bins --tests --target ${{ matrix.target }} ${{ inputs.flaky && '--run-ignored all' }}
cargo nextest run --workspace ${{ env.FEATURES }} --lib --bins --tests --target ${{ matrix.target }} ${{ inputs.flaky && '--run-ignored all' || '' }}
env:
RUST_LOG: "TRACE"
1 change: 1 addition & 0 deletions iroh/tests/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ fn cli_provide_addresses() -> Result<()> {
}

#[test]
#[ignore = "flaky"]
fn cli_rpc_lock_restart() -> Result<()> {
let dir = testdir!();
let iroh_data_dir = dir.join("data-dir");
Expand Down

0 comments on commit 36a6157

Please sign in to comment.