refactor: Extract validation and path helpers to utils module#15
Open
V1ki wants to merge 1 commit intoApexOpsStudio:mainfrom
Open
refactor: Extract validation and path helpers to utils module#15V1ki wants to merge 1 commit intoApexOpsStudio:mainfrom
V1ki wants to merge 1 commit intoApexOpsStudio:mainfrom
Conversation
- Create utils/validation.py with validate_description(), validate_task_file(), validate_task_id() - Create utils/paths.py with shared get_tasks_file() helper - Create utils/__init__.py - Update commands/add.py, commands/list.py, commands/done.py to import from utils - Update test_task.py imports to use utils.validation directly - No behavior changes; all existing tests pass Closes ApexOpsStudio#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3 — all validation logic and shared path helpers have been moved out of individual command files and into a new
utils/package.Changes
New files
utils/__init__.pyutils/validation.pyvalidate_description(),validate_task_file(),validate_task_id()utils/paths.pyget_tasks_file()— single source of truth for the storage pathUpdated files
commands/add.pyvalidate_description()+get_tasks_file(); import fromutilscommands/list.pyvalidate_task_file()+get_tasks_file(); import fromutilscommands/done.pyvalidate_task_id()+get_tasks_file(); import fromutilstest_task.pyvalidate_description/validate_task_idfromutils.validationAcceptance Criteria
utils/validation.pyutils/paths.pyTest run