Transfer data integration #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vycius
reviewed
Apr 25, 2024
| } | ||
| }) | ||
| .catch((error) => { | ||
| console.log(error); |
There was a problem hiding this comment.
Debugging errors will be challenging since Sentry won't capture these errors, and you'll only find them only in Docker logs. To mitigate this, consider configuring axios validateStatus (as explained here: link) and consistently return AxiosResponse instead of AxiosResponse|null from this function. This way, if an error occurs, Sentry will capture it along with supplementary information such as the transferReportDto values and you won't need to deal with null case.
| }) | ||
| @Post('/reports/transfer') | ||
| async transferReport( | ||
| @Body() transferReportDto: TransferReportDto, |
There was a problem hiding this comment.
Is it necessary to pass the entire TransferReportDto, or would just the ReportID suffice for this method?
vycius
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New endpoint to handle the transfer of a report. Once the transfer is complete the report gets updated with history edits and new external system fields.