Enable S3246 (#2204)

Enable S3246 and suppress existing warnings.
App-vNext · Jul 18, 2024 · d72f72d · d72f72d
1 parent f3bad33
commit d72f72d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/Polly/Caching/ITtlStrategy.cs b/src/Polly/Caching/ITtlStrategy.cs
@@ -12,7 +12,9 @@ public interface ITtlStrategy : ITtlStrategy<object>
 /// Defines a strategy for providing time-to-live durations for cacheable results.
 /// </summary>
 /// <typeparam name="TResult">The type of the result.</typeparam>
+#pragma warning disable S3246
 public interface ITtlStrategy<TResult>
+#pragma warning restore S3246
 {
     /// <summary>
     /// Gets a TTL for a cacheable item, given the current execution context.

diff --git a/src/Polly/CircuitBreaker/ICircuitBreakerPolicy.cs b/src/Polly/CircuitBreaker/ICircuitBreakerPolicy.cs
@@ -31,7 +31,9 @@ public interface ICircuitBreakerPolicy : IsPolicy
 /// Defines properties and methods common to all circuit-breaker policies generic-typed for executions returning results of type <typeparamref name="TResult"/>.
 /// </summary>
 /// <typeparam name="TResult">The type of the result.</typeparam>
+#pragma warning disable S3246
 public interface ICircuitBreakerPolicy<TResult> : ICircuitBreakerPolicy
+#pragma warning restore S3246
 {
     /// <summary>
     /// Gets the last result returned from a user delegate which the circuit-breaker handled.

diff --git a/src/Polly/Polly.csproj b/src/Polly/Polly.csproj
@@ -8,7 +8,7 @@
     <MutationScore>70</MutationScore>
     <IncludePollyUsings>true</IncludePollyUsings>
     <NoWarn>$(NoWarn);CA1010;CA1031;CA1051;CA1062;CA1063;CA1064;CA1710;CA1716;CA1724;CA1805;CA1815;CA1816;CA2211</NoWarn>
-    <NoWarn>$(NoWarn);S2223;S3215;S3246;S4039;S4457</NoWarn>
+    <NoWarn>$(NoWarn);S2223;S3215;S4039;S4457</NoWarn>
     <!--Public API Analyzers: We do not need to fix these as it would break compatibility with released Polly versions-->
     <NoWarn>$(NoWarn);RS0037;</NoWarn>
   </PropertyGroup>