Fix CA1033 warning #2193
Merged
Fix CA1033 warning #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2193 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 313 313
Lines 7162 7162
Branches 1060 1060
=======================================
Hits 6002 6002
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/Polly/Context.Dictionary.cs
Outdated
| @@ -4,7 +4,7 @@ | |||
| /// Context that carries with a single execution through a Policy. Commonly-used properties are directly on the class. Backed by a dictionary of string key / object value pairs, to which user-defined values may be added. | |||
| /// <remarks>Do not re-use an instance of <see cref="Context"/> across more than one execution.</remarks> | |||
| /// </summary> | |||
| public partial class Context : IDictionary<string, object>, IDictionary, IReadOnlyDictionary<string, object> | |||
| public sealed partial class Context : IDictionary<string, object>, IDictionary, IReadOnlyDictionary<string, object> | |||
There was a problem hiding this comment.
This is a breaking change for a public type as a user may have derived from it themselves for a custom class.
There was a problem hiding this comment.
Really. Then all that remains is to either suppress the error in the file header or close this PR
martincostello
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#1290
Details on the issue fix or feature implementation
Confirm the following
I will conditionally divide the partitions by directory names