Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix App Push Test #514

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix App Push Test #514

merged 3 commits into from
Dec 7, 2023

Conversation

kamilzyla
Copy link
Collaborator

@kamilzyla kamilzyla commented Dec 6, 2023

Changes

  1. Fix our App Push Test using a workaround for issue in renv.
  2. Add SHA to the commit messages generated by App Push Test, so the triggering commit can be easily identified just by looking at the list of workflow runs, even if the logs are no longer available.
  3. Add a badge back to the README. (See discussion.)
  4. Improve docs.

I have also regenerated the APP_PUSH_TEST_PAT (described in the docs); it will be good for another year.

How to test

See the workflow runs for App Push Test and the resulting Rhino Test (triggered manually for this branch).

@kamilzyla kamilzyla marked this pull request as ready for review December 6, 2023 08:52
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the fix. Please consider my comment in the README.

README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (091f967) 17.82% compared to head (ddd4df3) 17.82%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   17.82%   17.82%           
=======================================
  Files           9        9           
  Lines         404      404           
=======================================
  Hits           72       72           
  Misses        332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamilzyla kamilzyla merged commit 1887ca3 into main Dec 7, 2023
10 checks passed
@kamilzyla kamilzyla deleted the fix-app-push-test branch December 7, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants