-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Box function import count linter #537
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 28.57% 31.64% +3.07%
==========================================
Files 10 10
Lines 511 534 +23
==========================================
+ Hits 146 169 +23
Misses 365 365 ☔ View full report in Codecov by Sentry. |
Change max to 8. |
add a nolint selector to the e2etest app file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
box_func_import_count_linter()
.lintr
templateHow to test
box_func_import_count_linter()
exist.rhino
, version should be1.6.0.9003
, initialize a new rhino application then proceed to declare box imports.rhino::lint_r()
should find and point to all function imports that are more than 5 (default) per package/module.box_trailing_commas_linter = rhino::box_func_import_count_linter()
to.lintr
.rhino::lint_r()
should find and point to all function imports that are more than 5 (default) per package/module.