Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box function import count linter #537

Merged
merged 19 commits into from
Feb 20, 2024

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented Jan 11, 2024

Changes

How to test

  1. Unit tests for box_func_import_count_linter() exist.
  2. Locally install rhino, version should be 1.6.0.9003, initialize a new rhino application then proceed to declare box imports.
  3. rhino::lint_r() should find and point to all function imports that are more than 5 (default) per package/module.
  4. Or, with an existing rhino app, add box_trailing_commas_linter = rhino::box_func_import_count_linter() to .lintr.
  5. rhino::lint_r() should find and point to all function imports that are more than 5 (default) per package/module.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db8e2f8) 28.57% compared to head (f3e829e) 31.64%.

❗ Current head f3e829e differs from pull request most recent head 96683d7. Consider uploading reports for the commit 96683d7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   28.57%   31.64%   +3.07%     
==========================================
  Files          10       10              
  Lines         511      534      +23     
==========================================
+ Hits          146      169      +23     
  Misses        365      365              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radbasa
Copy link
Contributor Author

radbasa commented Jan 11, 2024

Change max to 8.

@radbasa radbasa requested a review from jakubnowicki January 12, 2024 09:39
@radbasa
Copy link
Contributor Author

radbasa commented Jan 12, 2024

add a nolint selector to the e2etest app file

@radbasa radbasa marked this pull request as ready for review January 26, 2024 04:59
Base automatically changed from box_universal_linter to main February 5, 2024 08:07
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubnowicki jakubnowicki merged commit b4722ba into main Feb 20, 2024
20 checks passed
@jakubnowicki jakubnowicki deleted the feature/box-function-import-count-linter branch February 20, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box function import count
3 participants