Skip to content

Upgrade Blueprint to 5.10.2 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2024
Merged

Upgrade Blueprint to 5.10.2 #100

merged 4 commits into from
May 16, 2024

Conversation

jakubsob
Copy link
Contributor

@jakubsob jakubsob commented May 13, 2024

Changes

  • Upgraded @blueprintjs/core to 5.10.2.
  • Replaced CSS classes namespaces, from bp4 to bp5.
  • Updated Tree component example to send only IDs of nodes to the server, it threw errors when parsing tree data to a JSON.
  • Updated ResizeSensor component. Styles of the wrapped component are un-mutable throwing an error.

Important

Remove "Install shiny.react with React 18.3.1" step from CI before merging.

How to test

Compare showcase app side by side with new version.

@jakubsob jakubsob marked this pull request as ready for review May 13, 2024 12:27
@jakubsob jakubsob changed the title Upgrade @blueprintjs/core to 5.10.2 Upgrade Blueprint to 5.10.2 May 13, 2024
@jakubsob jakubsob requested a review from jakubnowicki May 14, 2024 14:03
@jakubsob jakubsob self-assigned this May 14, 2024
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubsob jakubsob merged commit 87d2319 into main May 16, 2024
1 check passed
@jakubsob jakubsob deleted the upgrade-react branch May 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants