Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tweak: Subtle following/mutuals indicators #1128

Merged
merged 12 commits into from
Apr 29, 2024

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jul 9, 2023

outdated

Just for funsies for now. No idea how to get this to actually work properly.

Description

Adds a tweak that, rather than showing or completely hiding the following/mutuals icons in activity, makes them only appear as icons until the user hovers over them.

As this is a CSS vanity project, this has some unnecessary complexity to implement a smooth show-the-label animation. Specifically, putting a transition on the width property requires a hardcoded final width (grabbed via getBoundingClientRect) rather than just setting width: unset. It would be quite easy to remove this and make the label instantly appear; mention me if that's desired.

Testing steps

Enable the tweak and observe its functionality on the activity page and activity modal.

@marcustyphoon
Copy link
Collaborator Author

"screw it, whatever. if one is already manipulating text nodes one may as well rely on getBoundingClientRect too"

@marcustyphoon marcustyphoon changed the title New tweak: Subtle following/mutuals indicators New Tweak: Subtle following/mutuals indicators Aug 12, 2023
@marcustyphoon marcustyphoon marked this pull request as ready for review March 26, 2024 09:45
@AprilSylph AprilSylph self-requested a review April 29, 2024 07:44
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Copy link
Owner

@AprilSylph AprilSylph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice, so smooth

@marcustyphoon marcustyphoon merged commit dd66389 into AprilSylph:master Apr 29, 2024
2 checks passed
@marcustyphoon marcustyphoon deleted the subtle-activity-mutuals branch April 29, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants