-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CleanFeed: Add option to treat specified tags as mature #1185
CleanFeed: Add option to treat specified tags as mature #1185
Conversation
I don't think we can rename the |
Ah, makes sense, I'll set it to inherit the value of |
Any opinions on, sort of related to #982, the idea of allowing both |
I did think about that, and my reasoning for not adding it was that having the default values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good to me! Not sure if anyone has opinions about the default contents of the tags field; I could imagine having one but I can't think of anything.
Did that commit change anything, out of curiosity? (Not that it matters if it didn't; whichever way feels more clear is better!) |
I think I spent too long looking at stylesheets yesterday lol, for some reason I looked at it again and thought I had tried to use |
Yeah, to be fair, the fact that the previous way made us both have to think about (I started thinking about implicit type coercion) s a good sign that the new way is a clarity improvement :D Thanks for contributing! |
Description
Resolves #1178
Adds an option to treat specified tags as mature in the same way specified blogs can be treated as mature
Testing steps
Add a tag to the text field in the CleanFeed options and view a post with said tag