Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: Highlight preferences on search #1214

Merged

Conversation

marcustyphoon
Copy link
Collaborator

Description

Implements a super-simple highlight around preference options that match the current search.

Maybe this should be a different color in dark mode? Probably. I'm not much of a dark mode user, so maybe someone could weigh in on what feels appropriate. (Honestly, I'm pretty meh on the light mode color too.)

Resolves #1111

Testing steps

@marcustyphoon
Copy link
Collaborator Author

(font-weight: bold is another option.)

src/browser_action/popup.css Outdated Show resolved Hide resolved
src/browser_action/popup.css Outdated Show resolved Hide resolved
Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
@AprilSylph
Copy link
Owner

Hmm, maybe the yellow highlight is too much on dark mode. Firefox highlights matching text when searching for settings with that yellow on light mode, but with #003eaa (RGB: 0, 62, 170) on dark mode.

@marcustyphoon
Copy link
Collaborator Author

Ah, now I remember why I had added that line to the dark mode section :D

Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
@marcustyphoon
Copy link
Collaborator Author

An option:

.script li.search-highlighted {
  background: rgb(var(--search-highlight));
+  border-radius: 6px;
}

src/browser_action/configuration.css Outdated Show resolved Hide resolved
@AprilSylph
Copy link
Owner

Not sure how I feel about the rounded highlight. TBH I want to go all-in on the squareness and push up against the viewport edges but I don't remember how the padding is set up and don't want to either 1) resort to negative margins or 2) accidentally break something

I guess there aren't that many preference types to check and update, but still, I would rather review that as a separate PR.

Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
@marcustyphoon marcustyphoon merged commit 6159c8c into AprilSylph:master Dec 8, 2023
2 checks passed
@marcustyphoon marcustyphoon deleted the preference-search-highlight branch December 8, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preference pane search: highlight matching options
2 participants