-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup: Highlight preferences on search #1214
Popup: Highlight preferences on search #1214
Conversation
( |
Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Hmm, maybe the yellow highlight is too much on dark mode. Firefox highlights matching text when searching for settings with that yellow on light mode, but with |
Ah, now I remember why I had added that line to the dark mode section :D |
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Not sure how I feel about the rounded highlight. TBH I want to go all-in on the squareness and push up against the viewport edges but I don't remember how the padding is set up and don't want to either 1) resort to negative margins or 2) accidentally break something I guess there aren't that many preference types to check and update, but still, I would rather review that as a separate PR. |
Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Description
Implements a super-simple highlight around preference options that match the current search.
Maybe this should be a different color in dark mode? Probably. I'm not much of a dark mode user, so maybe someone could weigh in on what feels appropriate. (Honestly, I'm pretty meh on the light mode color too.)
Resolves #1111
Testing steps