Mass Deleter: Show blog name in confirm modal #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
requested review from
AprilSylph
and removed request for
AprilSylph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does a refactor I probably should have done a while ago (making
createTagSpan/createBlogSpanpart of the modals util rather than duplicating them) and then uses the latter to clarify the target blog in Mass Deleter's confirm modal, as per the linked issue.Resolves #1647.
Testing steps
Confirm that Mass Deleter, Tag Replacer, and Mass Privater have working blog highlights and (in the latter two cases) tag highlights in their modal confirmation windows.