Skip to content

[Feature] Support Invisible Columns #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: POLARDB_11_DEV
Choose a base branch
from
Open

[Feature] Support Invisible Columns #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3cc645
[Feature] Support Invisible Columns
YinZheng-Sun Jul 17, 2023
cd9a63f
fix: alter table
YinZheng-Sun Jul 19, 2023
af1722c
add modify grammar, consider partition table, visible coulumns should…
YinZheng-Sun Aug 17, 2023
1f24ed2
add join test
YinZheng-Sun Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/backend/access/common/tupdesc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,8 @@ equalTupleDescs(TupleDesc tupdesc1, TupleDesc tupdesc2)
return false;
if (attr1->attisdropped != attr2->attisdropped)
return false;
if (attr1->attisinvisible != attr2->attisinvisible)
return false;
if (attr1->attislocal != attr2->attislocal)
return false;
if (attr1->attinhcount != attr2->attinhcount)
Expand Down Expand Up @@ -644,6 +646,7 @@ TupleDescInitEntry(TupleDesc desc,
att->atthasmissing = false;
att->attidentity = '\0';
att->attisdropped = false;
att->attisinvisible = false;
att->attislocal = true;
att->attinhcount = 0;
/* attacl, attoptions and attfdwoptions are not present in tupledescs */
Expand Down Expand Up @@ -703,6 +706,7 @@ TupleDescInitBuiltinEntry(TupleDesc desc,
att->atthasmissing = false;
att->attidentity = '\0';
att->attisdropped = false;
att->attisinvisible = false;
att->attislocal = true;
att->attinhcount = 0;
/* attacl, attoptions and attfdwoptions are not present in tupledescs */
Expand Down
19 changes: 10 additions & 9 deletions src/backend/catalog/heap.c
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,37 +152,37 @@ static List *insert_ordered_unique_oid(List *list, Oid datum);
static FormData_pg_attribute a1 = {
0, {"ctid"}, TIDOID, 0, sizeof(ItemPointerData),
SelfItemPointerAttributeNumber, 0, -1, -1,
false, 'p', 's', true, false, false, '\0', false, true, 0
false, 'p', 's', true, false, false, '\0', false, false, true, 0
};

static FormData_pg_attribute a2 = {
0, {"oid"}, OIDOID, 0, sizeof(Oid),
ObjectIdAttributeNumber, 0, -1, -1,
true, 'p', 'i', true, false, false, '\0', false, true, 0
true, 'p', 'i', true, false, false, '\0', false, false, true, 0
};

static FormData_pg_attribute a3 = {
0, {"xmin"}, XIDOID, 0, sizeof(TransactionId),
MinTransactionIdAttributeNumber, 0, -1, -1,
true, 'p', 'i', true, false, false, '\0', false, true, 0
true, 'p', 'i', true, false, false, '\0', false, false, true, 0
};

static FormData_pg_attribute a4 = {
0, {"cmin"}, CIDOID, 0, sizeof(CommandId),
MinCommandIdAttributeNumber, 0, -1, -1,
true, 'p', 'i', true, false, false, '\0', false, true, 0
true, 'p', 'i', true, false, false, '\0', false, false, true, 0
};

static FormData_pg_attribute a5 = {
0, {"xmax"}, XIDOID, 0, sizeof(TransactionId),
MaxTransactionIdAttributeNumber, 0, -1, -1,
true, 'p', 'i', true, false, false, '\0', false, true, 0
true, 'p', 'i', true, false, false, '\0', false, false, true, 0
};

static FormData_pg_attribute a6 = {
0, {"cmax"}, CIDOID, 0, sizeof(CommandId),
MaxCommandIdAttributeNumber, 0, -1, -1,
true, 'p', 'i', true, false, false, '\0', false, true, 0
true, 'p', 'i', true, false, false, '\0', false, false, true, 0
};

/*
Expand All @@ -194,20 +194,20 @@ static FormData_pg_attribute a6 = {
static FormData_pg_attribute a7 = {
0, {"tableoid"}, OIDOID, 0, sizeof(Oid),
TableOidAttributeNumber, 0, -1, -1,
true, 'p', 'i', true, false, false, '\0', false, true, 0
true, 'p', 'i', true, false, false, '\0', false, false, true, 0
};

/* POLAR px */
static FormData_pg_attribute a8 = {
0, {"_px_worker_id"}, INT4OID, 0, sizeof(PxWorkerId),
PxWorkerIdAttributeNumber, 0, -1, -1,
true, 'p', 'i', true, false, false, '\0', false, true, 0
true, 'p', 'i', true, false, false, '\0', false, false, true, 0
};

static FormData_pg_attribute a9 = {
0, {"_root_ctid"}, TIDOID, 0, sizeof(ItemPointerData),
RootSelfItemPointerAttributeNumber, 0, -1, -1,
false, 'p', 's', true, false, false, '\0', false, true, 0
false, 'p', 's', true, false, false, '\0', false, false, true, 0
};
/* POLAR end */

Expand Down Expand Up @@ -691,6 +691,7 @@ HeapTuple heaptuple_from_pg_attribute(Relation pg_attribute_rel,
values[Anum_pg_attribute_atthasmissing - 1] = BoolGetDatum(new_attribute->atthasmissing);
values[Anum_pg_attribute_attidentity - 1] = CharGetDatum(new_attribute->attidentity);
values[Anum_pg_attribute_attisdropped - 1] = BoolGetDatum(new_attribute->attisdropped);
values[Anum_pg_attribute_attisinvisible - 1] = BoolGetDatum(new_attribute->attisinvisible);
values[Anum_pg_attribute_attislocal - 1] = BoolGetDatum(new_attribute->attislocal);
values[Anum_pg_attribute_attinhcount - 1] = Int32GetDatum(new_attribute->attinhcount);
values[Anum_pg_attribute_attcollation - 1] = ObjectIdGetDatum(new_attribute->attcollation);
Expand Down
Loading