-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing several bugs in the microservice implementation #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a mistake when calculating the length (mistakenly calculating string length, not word length), the last word in a text had the problem of raising an exception because the check if there is a next word did go wrong (as the nextWordIndex was always smaller than the actual maximum index in the words list)
…to hotfix/microservice_usage
dfuchss
reviewed
Sep 20, 2023
...on/src/main/java/edu/kit/kastel/mcse/ardoco/core/textproviderjson/textobject/PhraseImpl.java
Outdated
Show resolved
Hide resolved
...astel/mcse/ardoco/core/text/providers/informants/corenlp/textprocessor/HttpCommunicator.java
Outdated
Show resolved
Hide resolved
dfuchss
reviewed
Sep 21, 2023
...astel/mcse/ardoco/core/text/providers/informants/corenlp/textprocessor/HttpCommunicator.java
Outdated
Show resolved
Hide resolved
...astel/mcse/ardoco/core/text/providers/informants/corenlp/textprocessor/HttpCommunicator.java
Outdated
Show resolved
Hide resolved
…doco/core/text/providers/informants/corenlp/textprocessor/HttpCommunicator.java Co-authored-by: Dominik Fuchß <dominik.fuchss@kit.edu>
…doco/core/text/providers/informants/corenlp/textprocessor/HttpCommunicator.java Co-authored-by: Dominik Fuchß <dominik.fuchss@kit.edu>
dfuchss
approved these changes
Sep 22, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hotfix targets several issues in the microservice implementation that were uncovered recently after the microservice was actually used and initial bugs were fixed in the commits 7b35c21 and 0661657:
TextImpl.getLength()
for the microservice version: The previous version returned the String length, not the number of words.PosTag
enum as it was basically duplicate code.equals
andhashcode
of WordImpl of the microservice. Now, the previous and next words are not part of these as otherwise all words of the whole text needs to be compared each time when comparing two words.