Skip to content

Removing aspectjrt check #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

ashj11
Copy link

@ashj11 ashj11 commented Aug 2, 2019

Related to #93.
There are two cases in this.

  1. In the case of certain plugins like Firebase, they do operate on the jars and provide the extracted class files are input for the next transformation. In this case, though the aspectjrt class files are present in the path, the above check will fail.
  2. In the case of android integration tests, the aspectj runtime doesn't seem to be explicitly passed( not sure why ). But if i bypass the check and still allow it to weave, the weaving seems to be happening just fine. And the test passes.
  3. Even if we remove the hasAjRT check, If the aspectjrt is not genuinely present, then weaving fails with a very clear message to check for aspectrt.jar in the classpath, which seems to be good enough.
    @Archinamon given point 3, was there any strong reason for adding the jar presence check? If not, can we remove it.

@Archinamon
Copy link
Owner

Clear reasons to remove it :)

@Archinamon Archinamon merged commit 4d52317 into Archinamon:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants