Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraria: 1.4.4 and Calamity support #3847

Open
wants to merge 129 commits into
base: main
Choose a base branch
from

Conversation

Seldom-SE
Copy link
Collaborator

What is this fixing or adding?

For the Terraria world:

  • Terraria 1.4.4 support
  • Calamity mod support
  • getfixedboi (1.4.4 secret seed) support
  • Expanded achievement locations options and made them more flexible
  • Made Checks.py easier to maintain

The achievements options were a mutually exclusive list including "None", "Exclude Grindy", "Exclude Fishing", and "All". But now, they're a list of booleans that can be toggled independently, including "Early Pre-Hardmode achievements", "Normal achievements", "Grindy achievements", and "Fishing quest achievements".

How was this tested?

5 public testing releases and my own test runs

If this makes graphical changes, please attach screenshots.

Behold, options!

image


Sorry for the mega-PR.

I've talked to a Calamity dev about having them release a separate mod on the workshop that's just Calamity, but it stays on whatever version we support. If that ends up happening, I'll make a follow-up PR updating the docs accordingly.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Aug 25, 2024
@Seldom-SE Seldom-SE added the is: enhancement Issues requesting new features or pull requests implementing new features. label Aug 25, 2024
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a brief look

worlds/terraria/Options.py Outdated Show resolved Hide resolved
worlds/terraria/Options.py Outdated Show resolved Hide resolved
worlds/terraria/__init__.py Outdated Show resolved Hide resolved
worlds/terraria/__init__.py Outdated Show resolved Hide resolved
worlds/terraria/Rules.dsv Outdated Show resolved Hide resolved
@Seldom-SE
Copy link
Collaborator Author

Thanks for the reviews, y'all. I'll get to them when I can, but I've been busy

worlds/terraria/Rules.dsv Outdated Show resolved Hide resolved
Seldom-SE and others added 5 commits January 28, 2025 20:48
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
…reqs, fix Eldritch Soul Artifact, Ceaseless Void reqs Dungeon
worlds/terraria/Rules.dsv Outdated Show resolved Hide resolved
worlds/terraria/Rules.dsv Outdated Show resolved Hide resolved
Seldom-SE and others added 2 commits February 5, 2025 14:08
…er in Calamity

Co-authored-by: Seatori <92278897+Seatori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants