-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraria: 1.4.4 and Calamity support #3847
Open
Seldom-SE
wants to merge
129
commits into
ArchipelagoMW:main
Choose a base branch
from
Seldom-SE:calamity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+651
−371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a brief look
Seatori
reviewed
Oct 5, 2024
Thanks for the reviews, y'all. I'll get to them when I can, but I've been busy |
Seatori
reviewed
Oct 21, 2024
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
…reqs, fix Eldritch Soul Artifact, Ceaseless Void reqs Dungeon
Seatori
reviewed
Jan 31, 2025
Seatori
reviewed
Feb 5, 2025
…er in Calamity Co-authored-by: Seatori <92278897+Seatori@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: enhancement
Issues requesting new features or pull requests implementing new features.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
For the Terraria world:
Checks.py
easier to maintainThe achievements options were a mutually exclusive list including "None", "Exclude Grindy", "Exclude Fishing", and "All". But now, they're a list of booleans that can be toggled independently, including "Early Pre-Hardmode achievements", "Normal achievements", "Grindy achievements", and "Fishing quest achievements".
How was this tested?
5 public testing releases and my own test runs
If this makes graphical changes, please attach screenshots.
Behold, options!
Sorry for the mega-PR.
I've talked to a Calamity dev about having them release a separate mod on the workshop that's just Calamity, but it stays on whatever version we support. If that ends up happening, I'll make a follow-up PR updating the docs accordingly.