The Witness: The Secret Feature #4370

NewSoupVi · 2024-12-13T20:01:42Z

Obviously I would prefer if this could stay secret.

Peer reviewers are exempt, obviously. Looking at the code it should be obvious what it is.

Without giving too much away, there is some urgency to merging this, but it's not a Christmas feature, so not that much urgency.

There is a functional client supporting this feature now: Click

ScipioWright

Just reviewed the code, did not test gen, do not have a client for it to test in-game.
Nothing stuck out as wrong or odd.

NewSoupVi · 2024-12-15T09:16:04Z

Because this came up:
Ruff has new rules / rules that came into effect because we killed Python 3.9

UP006 asks me to change every List to list. I will get to this eventually, but not as part of this PR.
UP035 is similar, it asks me to get rid of deprecated typing imports.
RUF021 asks me to put parentheses around and conditions if chained with an or. This is a good change, but unrelated to this PR. I will open a separate PR for this most likely.

I might pull the ruff changes out into a separate PR so that my other PRs also benefit from these ignores

ScipioWright

Actually did test gens and such this time, still no issues found. Did find a few things to suggest, though.

worlds/witness/options.py

worlds/witness/player_logic.py

worlds/witness/options.py

worlds/witness/player_logic.py

worlds/witness/rules.py

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

…nothing to do with location names

NewSoupVi · 2024-12-23T01:28:14Z

There's a client now.

…g gen, don't review it :D)

NewSoupVi · 2025-02-13T18:01:56Z

wtf

NewSoupVi · 2025-02-13T18:04:02Z

Noone saw anything :)

…lago into secret_feature

* Secret Feature * Fixes * Fixes and unit tests * renaming some variables * Fix the thing * unit test for elevator egg * Docstring * reword * Fix duplicate locations I think? * Remove debug thing * Add the tests back lol * Make it so that you can exclude an egg to disable it * Improve hint text for easter eggs * Update worlds/witness/options.py Co-authored-by: Scipio Wright <scipiowright@gmail.com> * Update worlds/witness/player_logic.py Co-authored-by: Scipio Wright <scipiowright@gmail.com> * Update worlds/witness/options.py Co-authored-by: Scipio Wright <scipiowright@gmail.com> * Update worlds/witness/player_logic.py Co-authored-by: Scipio Wright <scipiowright@gmail.com> * Update worlds/witness/rules.py Co-authored-by: Scipio Wright <scipiowright@gmail.com> * Update test_easter_egg_shuffle.py * This was actually not necessary, since this is the Egg requirements, nothing to do with location names * Move one of them * Improve logic * Lol * Moar * Adjust unit tests * option docstring adjustment * Recommend door shuffle * Don't overlap IDs * Option description idk * Change the way the difficulties work to reward playing higher modes * Fix merge * add some stuff to generate_data_file (this file is not imported during gen, don't review it :D) * oop * space * This can be earlier than I thought, apparently. * buffer * Comment * Make sure the option is VERY visible * Some mypy stuff * apparently ruff wants this * . * durinig * Update options.py * Explain the additional effects of each difficulty * Fix logic of flood room secret * Add Southern Peninsula Area * oop --------- Co-authored-by: Scipio Wright <scipiowright@gmail.com>

NewSoupVi added 3 commits December 13, 2024 19:49

Secret Feature

4768e1d

Fixes

721cf4d

Fixes and unit tests

380b667

github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Dec 13, 2024

NewSoupVi added 5 commits December 13, 2024 21:09

renaming some variables

78a9026

Fix the thing

41b47bf

unit test for elevator egg

eb225f7

Docstring

fc87b75

reword

c7391e3

NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Dec 13, 2024

NewSoupVi added 5 commits December 13, 2024 21:38

Fix duplicate locations I think?

6d4a2b4

Remove debug thing

cab9133

Add the tests back lol

e89e82a

Make it so that you can exclude an egg to disable it

ba38dcf

Improve hint text for easter eggs

5e476d9

ScipioWright approved these changes Dec 15, 2024

View reviewed changes

NewSoupVi and others added 8 commits December 15, 2024 22:21

Update worlds/witness/options.py

eb4672b

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

Update worlds/witness/player_logic.py

f83a940

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

Update worlds/witness/options.py

56ed4da

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

Update worlds/witness/player_logic.py

b9d7d40

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

Update worlds/witness/rules.py

a31fb75

Co-authored-by: Scipio Wright <scipiowright@gmail.com>

Update test_easter_egg_shuffle.py

8157d0b

This was actually not necessary, since this is the Egg requirements, …

50d618f

…nothing to do with location names

Move one of them

e9e535c

NewSoupVi added 3 commits December 23, 2024 13:10

Improve logic

226d500

Lol

4fc3fa7

Merge branch 'main' into secret_feature

fdcb659

NewSoupVi added 6 commits February 2, 2025 21:00

add some stuff to generate_data_file (this file is not imported durin…

01575de

…g gen, don't review it :D)

oop

4c6c062

space

ef7bab4

This can be earlier than I thought, apparently.

9b3b012

buffer

08c213c

Comment

6133eb3

ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 4, 2025

NewSoupVi added 6 commits February 5, 2025 01:23

Make sure the option is VERY visible

052642e

Some mypy stuff

5f33078

apparently ruff wants this

3586d5d

.

43503d5

durinig

2838216

Update options.py

117b1df

github-actions bot added the affects: core Issues/PRs that touch core and may need additional validation. label Feb 13, 2025

Explain the additional effects of each difficulty

3a96a87

NewSoupVi removed the affects: core Issues/PRs that touch core and may need additional validation. label Feb 13, 2025

NewSoupVi force-pushed the secret_feature branch from f198d15 to 3a96a87 Compare February 13, 2025 18:03

NewSoupVi added 5 commits February 13, 2025 19:04

Merge branch 'main' into secret_feature

6ebf82f

Fix logic of flood room secret

92f85c7

Merge branch 'secret_feature' of https://github.com/NewSoupVi/Archipe…

505a7e6

…lago into secret_feature

Add Southern Peninsula Area

099aad4

oop

337f3cf

NewSoupVi merged commit 08b3b3e into ArchipelagoMW:main Mar 8, 2025
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

The Witness: The Secret Feature #4370

The Witness: The Secret Feature #4370

Uh oh!

NewSoupVi commented Dec 13, 2024 •

edited

Loading

Uh oh!

ScipioWright left a comment

Uh oh!

NewSoupVi commented Dec 15, 2024

Uh oh!

ScipioWright left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NewSoupVi commented Dec 23, 2024

Uh oh!

NewSoupVi commented Feb 13, 2025

Uh oh!

NewSoupVi commented Feb 13, 2025

Uh oh!

Uh oh!

Uh oh!

The Witness: The Secret Feature #4370

The Witness: The Secret Feature #4370

Uh oh!

Conversation

NewSoupVi commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ScipioWright left a comment

Choose a reason for hiding this comment

Uh oh!

NewSoupVi commented Dec 15, 2024

Uh oh!

ScipioWright left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NewSoupVi commented Dec 23, 2024

Uh oh!

NewSoupVi commented Feb 13, 2025

Uh oh!

NewSoupVi commented Feb 13, 2025

Uh oh!

Uh oh!

Uh oh!

NewSoupVi commented Dec 13, 2024 •

edited

Loading