Stardew Valley: Move progressive tool options handling in features #4374
+268
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug but turns out it works
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: refactor/cleanup
agilbert1412
suggested changes
Dec 17, 2024
Jouramie
added a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 17, 2024
Jouramie
force-pushed
the
StardewValley/move-tool-handling-in-feature
branch
from
8bdd6fd to
5d31729
Compare
beauxq
approved these changes
Jan 14, 2025
agilbert1412
suggested changes
Jan 20, 2025
…ve-tool-handling-in-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
In prevision of adding the option to start without any tools, I'm moving the handling of the progressive tools to the feature architecture, introduced with 6.x.x.
The next steps will be to actually add the option and review the logic, but in order to make those changes more reviewable, I'm trying to break down the changes in more manageable PRs.
The tool distribution stuff should also be handled by content packs instead of being directly in the feature. This would allow better handling of potential new tools or materials from mods. However, it did not seem necessary right now.
How was this tested?
Added some unit tests to make sure the tool count is correct depending on the options. I also generated games with combination or progressive tools / progressive skills, and the item count was fine.
If this makes graphical changes, please attach screenshots.
N/A