-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LADX: Autotracker improvements #4445
base: main
Are you sure you want to change the base?
LADX: Autotracker improvements #4445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its been tested in the beta release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this in three Syncs, working flawlessly. An Async is on the way to test this further but I'd love to have this in 0.6.0
What is this fixing or adding?
This brings the client's built in autotracking up to parity with Magpie's standalone autotracker:
SetNotify
for the key so that players can co-op the entrances in a slot.The main RAM reading code has been expanded and modified to support this. Retroarch is pretty slow to read RAM - the added reads should've slowed the main loop down, but some of the existing reads weren't being cached. In my testing, the main loop actually takes less time per tick now.
Most of this is ported from Magpie's autotracker. The original code is MIT licensed, and I'm the author.
How was this tested?
I tested each change as thoroughly as I could as I went, and play tested various scenarios.
This code is currently in the LADX beta build and being tested by users.