TUNIC: Fix combat logic poorly interacting with playthrough #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: refactor/cleanup
ScipioWright
changed the title
ScipioWright
added
is: bug/fix
|
Just rolled this PR into this other one since it's too relevant not to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Swamp and Cathedral were separated for no real reason in the combat logic -- they have the same stat requirements.
So now they are not separated.
Also Swamp gets checked on its own since it breaks the pattern of increasing stat requirements like Gauntlet does. This should fix an issue where it'll think some areas are inaccessible during playthrough calcs due to the order they do stuff in.
There's a separate fix for a logic bug being PR'd separately later
How was this tested?
Test gens, making sure it didn't change which checks were in logic in a test case.