MMBN3: Allow use of a specified program for rom_start #4575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yping and docstring accordingly
github-actions
bot
added
the
waiting-on: peer-review
qwint
reviewed
Jan 29, 2025
ScipioWright
added
the
is: enhancement
qwint
reviewed
Mar 10, 2025
Co-authored-by: qwint <qwint.42@gmail.com>
qwint
reviewed
Mar 28, 2025
Comment on lines
+293
to
+294
| from settings import get_settings | ||
| auto_start = get_settings().mmbn3_options.rom_start |
There was a problem hiding this comment.
i know you implemented literally the code i told you to but i was reminded between making that comment and now that this is the better way for world-specific code to interact with the settings api
Suggested change
| from settings import get_settings | |
| auto_start = get_settings().mmbn3_options.rom_start | |
| from worlds.mmbn3 import MMBN3World | |
| auto_start = MMBN3World.settings.rom_start |
19 tasks
|
Woops, didn't know this one was still waiting. I purged stale branches and it closed this one. I restored the branch and added the changes to #5077 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes an issue where specifying a file or program for rom_start in MMBN3's host.yaml options just opened it in the default program anyway due to truthiness of a string
How was this tested?
Changed rom_start to notepad, loaded patch, confirmed notepad opened instead of bizhawk.