MMBN3: Allow use of a specified program for rom_start #4575
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yping and docstring accordingly
github-actions
bot
added
the
waiting-on: peer-review
qwint
reviewed
Jan 29, 2025
| """ | ||
| Set this to false to never autostart a rom (such as after patching), | ||
| true for operating system default program | ||
| Alternatively, a path to a program to open the .z64 file with |
There was a problem hiding this comment.
is z64 the right file extension?
| rom_file: RomFile = RomFile(RomFile.copy_to) | ||
| rom_start: bool = True | ||
| rom_start: typing.Union[RomStart, bool] = True |
There was a problem hiding this comment.
Suggested change
| rom_start: typing.Union[RomStart, bool] = True | |
| rom_start: RomStart | bool = True |
I believe we can now do typings like this instead of typing.Union
ScipioWright
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes an issue where specifying a file or program for rom_start in MMBN3's host.yaml options just opened it in the default program anyway due to truthiness of a string
How was this tested?
Changed rom_start to notepad, loaded patch, confirmed notepad opened instead of bizhawk.