Skip to content

WebHost: Validation for webworld themes #5083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josephwhite
Copy link
Contributor

What is this fixing or adding?

Uses the available list of themes as a validation check for supplied web world themes. Also removes a duplicated function.

How was this tested?

Hosting a local server and observing invalid themes getting turned to grass.

If this makes graphical changes, please attach screenshots.

Transforms a "This page is out of logic!" error to grass theme.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Jun 4, 2025
@qwint qwint added waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. labels Jun 4, 2025
@josephwhite josephwhite changed the title WebHost: Validation for themes WebHost: Validation for webworld themes Jun 25, 2025
Copy link
Contributor

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants