LADX: Fix force_start_item sometimes placing a different copy of the item than it is removing from the itempool #5110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empool that it's placing
github-actions
bot
added
the
waiting-on: peer-review
threeandthreee
approved these changes
Jun 13, 2025
NewSoupVi
added
is: bug/fix
Exempt-Medic
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itempool.remove checks the "weak equality" defined in
Item.__eq__. This means that this part of the code is potentially removing a different copy of the start item from the itempool than it is placing, leaving a placed item in the itempool and removing an unplaced item.This is probably bad & fails this new assert that I want to add: #5109