Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr/various10 #1075

Merged
merged 89 commits into from
Jun 30, 2024
Merged

Pr/various10 #1075

merged 89 commits into from
Jun 30, 2024

Conversation

uli42
Copy link
Member

@uli42 uli42 commented Jun 26, 2024

many small commits

uli42 added 30 commits March 28, 2024 10:41
@uli42
Screen.c: fix missing ;
f326d04
@uli42
Pixmap.c: fix fprintf call
1cef3ac 
Due to the , the second line was taken as the first argument leading to weird output.
@uli42
Drawable.c: fix build errors with TEST enabled
39f67db
@uli42
Events.c: explain define
5fb545f
@uli42
os/Imakefile: only compile rpcauth if we have libtirpc
ade8d61 
glibc no longer has rpc included, so we can only compile when tirpc
is available
@uli42
Screen.c, Pixmap.c: silence some compiler warnings
6785c93
@uli42
Pixmap.c: add missing [] to TEST output
7747791
@uli42
NXevents.c: add/improve comments
c2682cf
@uli42
NXProperty.c: fix indentations, format comments
66643fe
@uli42
hw/nxagent/NXglxext.c: fix missing opcode variable in TEST mode
aac78fd 
also add soem whitespace fix
@uli42
Imake: drop BuildModuleInSubdir
a3e11cc 
Set to No and Only checked by GL
@uli42
NXglyphcurs.c: add missing TEST/DEBUG defines
1df44b7
@uli42
NXglyphcurs.c: remove register keywords
ac45ae3
@uli42
NXglyphcurs.c: mark NX changes
9df98ab
@uli42
Window.c: improve some TEST/DEBUG output
d1754f8 
add [] around values where they were missing
@uli42
Window.c: add debug output
dd4f18f
@uli42
NXshm.c: remove unused extern
191450a
@uli42
Render.c: fix comments
911108f
@uli42
Render.c: add some DEBUG output
5964974
@uli42
Render.c: add some DEBUG output
9f59723
@uli42
Render.c: Fix: init variable once outside the loop
a70c8be 
otherwise it would be reinitialized for every interation.

This was errornously moved in commit 56aaea9
@uli42
NXglyph.c: reformat ResizeGlyphHash
b95fe00
@uli42
Events.c: use existing functions for CriticalOutputPending
a7a9f35
@uli42
Events.c: make nxagentDebugInput a Boolean
c4887d2 
because that's what it is...
@uli42
NXrender.c: fix indentation
35544d4
@uli42
GC.c: improve comment
79272c6
@uli42
Client.c: fix TEST output
436034c
@uli42
NXproperty.y/property.c: fix comments
55e798a
@uli42
NXproperty.c: fix ifdef indentation
cc9922e
@uli42
Pixmap.c: fix TEST output
c1365bb
uli42 added 22 commits June 2, 2024 15:40
@uli42
Render.c: improve DEBUG/TEST output
924ace0
@uli42
Screen.c: fix comment
f045002
@uli42
Events.c: make nxagentInputEvent a Boolean
621a67c
@uli42
Events.c: make sendKey a Boolean
83a75c9
@uli42
Events.c: NewOutputPending is a Boolean
2c6f4dc
@uli42
Events.c: make event handling functions return Booleans
168d6e6
@uli42
Events.c: disable unused function
a22d140 
no need to compile if it is unused
@uli42
NXresource.c: make nxagentFindClientResource return a Boolean
13ef429
@uli42
NXresource.c: make nxagentSwitchResourceType return a Boolean
f54d46a
@uli42
NXresource.c: make nxagentSwitchResourceType static
5d2b64e 
is only used inside this module
@uli42
GCOps.c: drop unused function nxagentBitBlitHelper
20e360c
@uli42
Window.c: improve TEST/DEBUG output
77fa3c0
@uli42
Window.c: add missing include
9266d70 
required for nxagentImagePad
@uli42
Window.c: fix comments
9974507
@uli42
Window.c: use shorter macro to retrieve the remote window
48fd593 
nxagentWindowPriv(pWin)->window is identical to nxagentWindow(pWin)
@uli42
Window.c: align identical code
4bed83a 
nxagentCreateWindow and nxagentReconnectWindow are very similar. So let's try
to give identical code identical structure.
@uli42
Render.c: simplify nxagent{Create,Change}Picture
46e7e47 
improve readabiliy by using a macro for repeated code
@uli42
Render.c: fix format specifiers
18073ad
@uli42
Render.c: merge masks in nxagentReconnectPicture
5f7c8e7
@uli42
Render.c: some simplifications
1873e50
@uli42
Render.c: fix typo
cefbf13
@uli42
Render.c: improve DEBUG/TEST output
cbae2ae 
add [] around placeholders just as everywhere else.
@uli42 uli42 requested a review from sunweaver June 26, 2024 20:36
sunweaver
sunweaver approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@sunweaver sunweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunweaver sunweaver merged commit 314ec41 into ArcticaProject:3.6.x Jun 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunweaver sunweaver sunweaver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uli42 @sunweaver