Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design the nxagent dialog callbacks #387

Open
wants to merge 7 commits into
base: 3.6.x
Choose a base branch
from
Open

Re-design the nxagent dialog callbacks #387

wants to merge 7 commits into from

Commits on Mar 8, 2017

  1. Xserver/Imakefile: Switch to pkg-config --libs-only-l zlib. 

      pkg-config --libs zlib in Debian jessie returns buggy linker parameters. It
  includes the system's default multi-arch path for shared libs.

  When linking nxagent, having the system's default shared library path
  explicitly listed as a "-L" linker option confuses linking against the
  libXcomp*.so files in the build path.

  When linking nxagent, we don't want to link against the system's
  libXcomp*.so files, we want it to get linked explicitly against
  the just built libXcomp*.so files in nxcomp/ and nxcompshad/.

  This change assumes that -lzlib is always available in the system's
  default shared library path.
    @sunweaver
    sunweaver committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    19975fa View commit details
    Browse the repository at this point in the history

  2. Xserver/Imakefile: Change order of linker options, to that self-built… 

    … components get mentioned first in the nxagent linker command.
    @sunweaver
    sunweaver committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    7afb0ac View commit details
    Browse the repository at this point in the history

  3. Xserver/Imakefile: Drop redundant library path option -L../../../nx-X… 

    …11/exports/lib when linking nxagent. As -L../../exports/lib is already present and points to the same location.
    @sunweaver
    sunweaver committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    c30386e View commit details
    Browse the repository at this point in the history

  4. nxcomp/Children.cpp: Don't generate warnings with duplicated NX paths. 

     Fixes ArcticaProject#370.
    @sunweaver
    sunweaver committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    45066e2 View commit details
    Browse the repository at this point in the history

  5. nxcomp,hw/nxagent/Dialog.c: Basic implementation of the NXTransCallba… 

    …cksDispatcher.

  - As a starting point for newly implementing a callbacks dispatcher
    scenario that allows for capturing various session events and executing
    external tools (like dialog boxes, pulldown menus, etc.).
  - The callbacks dispatcher approach will finally deprecate the NX_CLIENT
    env var related code path in later releases of nxcomp/nxagent.

 In the nxagent binary:
 For now, the callbacks dispatcher code path is taken if the env var
 NX_CALLBACKS_DISPATCHER is set to an application that handles
 the dispatching of callbacks from nxagent.

 in /usr{/local}/bin/nxagent:
 If NX_CALLBACKS_DISPATCHER is an empty string, callbacks are disabled.

 If NX_CALLBACKS_DISPATCHER is unset and the dispatcher command
 /usr/{local/}{<multiarch>/]nx/bin/nxagent-callbacks-dispatcher cannot be
 found, nxagent falls back to its old NX_CLIENT related code path.
    @sunweaver
    sunweaver committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    c9fed1b View commit details
    Browse the repository at this point in the history

  6. hw/nxagent/Dialog.c: Drop unused dialog for DIALOG_DISABLE_XKB_LOCAL. 

     Fixes ArcticaProject#383.
    @sunweaver
    sunweaver committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    44c9e78 View commit details
    Browse the repository at this point in the history

  7. bin/nxagent.in: If not-yet-set and a script named nxagent-callbacks-d… 

    …ispatcher exists in the system's PATH, use this script's full path to set NX_CALLBACKS_DISPATCHER env var.
    @sunweaver
    sunweaver committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    0922b66 View commit details
    Browse the repository at this point in the history