Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac refresh the mac build to deploy app and dmg #1297

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Aug 29, 2023

update the repo with the needed information related to the creation of an app Signed to be deployed on mac
still under draft for now

Comment on lines +180 to 182
CONFIG += x86_64 arm64
CONFIG -= x86
QMAKE_MACOSX_DEPLOYMENT_TARGET = 10.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure but I think its worth a test. Please remove the 2 CONFIG lines and use QMAKE_APPLE_DEVICE_ARCHS = x86_64 arm64 instead and use QMAKE_MACOSX_DEPLOYMENT_TARGET = 10.14 I think mojave is old enough.
Perhaps this allows building a Universal binary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i was on it but look like i should to that
CONFIG -= x86
CONFIG -= x86_64
CONFIG += x86 arm64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me find an associated mac, I will also try to create different build and we can all test

Copy link
Contributor

@Youw Youw Sep 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the MACOSX_DEPLOYMENT_TARGET doesn't automatically enables Universal binary
that is a separate option
more than that, when building an arm64 or a universal binary - the niminum supported/deployement target is maxed to at least 10.14 automatically and w/o a warning, but only the the arm64 part of the binrary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants