Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

Update .gitmodules #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

davidbitton
Copy link

moved to firewall friendly URLs; removed "git:"

moved to firewall friend URLs; removed "git:"
@magicrub
Copy link

looks fine to me, @lucasdemarchi ?

@lucasdemarchi
Copy link

LGTM

@lucasdemarchi
Copy link

humn... I think the reason to use git:// protocol is that it's read-only, so one would avoid accidental pushes to a submodule. I'm not against changing it though.

@davidbitton
Copy link
Author

wouldn't you need to be a maintainer to be able to push?

On Tue, Jun 21, 2016 at 5:06 PM Lucas De Marchi notifications@github.com
wrote:

humn... I think the reason to use git:// protocol is that it's read-only,
so one would avoid accidental pushes to a submodule. I'm not against
changing it though.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#56 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAQ612Ljs1TiMgPHaM_fchbR4L3uMqV3ks5qOFI6gaJpZM4I7Adg
.

David B. Bitton
Code No Evil, LLC
Code Made Fresh Daily

@gmorph
Copy link

gmorph commented Jun 22, 2016

git doesn't have fine grained permissions so there are lots of people with "Maintainer" rights who administer issues, pull request comments, labels etc but don't actually ever "push" into master. That's where the git:// comes in as it allows all those other functions but as Lucas has said its read only to avoid accidental pushes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants