Skip to content

Fixed Build Issue #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tcyrus wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed Build Issue #5

tcyrus wants to merge 3 commits into from

Conversation

@tcyrus
Copy link

@tcyrus tcyrus commented Mar 12, 2020 •
edited
Loading

Fixes #4, which was caused by an incorrect configuration of rustcord-sys.

tcyrus and others added 3 commits March 12, 2020 19:08
@tcyrus
Update build.rs
80526ee
@tcyrus
Update build.rs
c3461dd
@tcyrus
Fixed Formatting
574f413 
Rewrote based on cmake crate example and rust-discord-rpc-src crate
@tcyrus
Copy link
Author

tcyrus commented Mar 23, 2020

@AregevDev Any problem with this?

@AregevDev
Copy link
Owner

AregevDev commented Mar 23, 2020 •
edited
Loading

Hi, I will review it in about an hour, wasn't aware this happens. Thanks

@AregevDev
Copy link
Owner

AregevDev commented Mar 23, 2020

Did you test to see if docs.rs can build it?
I think the issue might be with the CMake script itself, it tries to download rapidjson, but fails since it's a read only system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs.rs failed to build

2 participants

@tcyrus @AregevDev