chore: clean up code/comments #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerargus
approved these changes
Aug 9, 2023
namrapatel
reviewed
Aug 9, 2023
| @@ -1,69 +0,0 @@ | |||
| package utils | |||
There was a problem hiding this comment.
looks good but didn't scott mention something about him creating this decimal library and he wanted someone to review it? are we upstreaming this to cardinal or just getting rid of it completely? what was it used for before?
There was a problem hiding this comment.
yeah we should upstream something like this to cardinal lib. we need deterministic floating point lib
namrapatel
approved these changes
Aug 9, 2023
smsunarto
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configstruct to remove the thing we are configuring (bit of an anti-pattern)Mustutility (its generally not advised to make assumptions in Go libraries about how people want to handle their errors)