Skip to content

fix: CI issues for openai agents #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: CI issues for openai agents #2367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d2e2ad
fix(openai-agengs): Fixing CI issues for openai-agents
satyadevai Oct 29, 2025
96af527
Fixing typeing for the function call output
satyadevai Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions ...strumentation-openai-agents/src/openinference/instrumentation/openai_agents/_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,23 @@ def _get_attributes_from_response_custom_tool_call_output_param(
if (call_id := obj.get("call_id")) is not None:
yield f"{prefix}{MessageAttributes.MESSAGE_TOOL_CALL_ID}", call_id
if (output := obj.get("output")) is not None:
yield f"{prefix}{MessageAttributes.MESSAGE_CONTENT}", output
if isinstance(output, str):
yield f"{prefix}{MESSAGE_CONTENT}", output
elif isinstance(output, list):
for i, item in enumerate(output):
if item["type"] == "input_text":
yield (
f"{prefix}{MESSAGE_CONTENTS}.{i}.{MESSAGE_CONTENT_TEXT}",
Copy link
Collaborator Author

@satyadevai satyadevai Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caroger, could you please confirm whether the attribute name is correct?. Based on my understanding, FunctionCallOutput can contain either a string or a List[Union[ResponseInputTextContentParam, ResponseInputImageContentParam, ResponseInputFileContentParam]]. I’ve assumed it will be a list of contents, so I’m passing these values as contents.

item["text"] or "",
)
elif item["type"] == "input_image":
# TODO: handle the input image type for the tool input
pass
elif item["type"] == "input_file":
# TODO: handle the input file type for the tool input
pass
elif TYPE_CHECKING:
assert_never(item["type"])


def _get_attributes_from_function_call_output(
Expand All @@ -359,7 +375,24 @@ def _get_attributes_from_function_call_output(
) -> Iterator[tuple[str, AttributeValue]]:
yield f"{prefix}{MESSAGE_ROLE}", "tool"
yield f"{prefix}{MESSAGE_TOOL_CALL_ID}", obj["call_id"]
yield f"{prefix}{MESSAGE_CONTENT}", obj["output"]
if (output := obj.get("output")) is not None:
if isinstance(output, str):
yield f"{prefix}{MESSAGE_CONTENT}", output
elif isinstance(output, list):
for i, item in enumerate(output):
if item["type"] == "input_text":
yield (
f"{prefix}{MESSAGE_CONTENTS}.{i}.{MESSAGE_CONTENT_TEXT}",
item["text"] or "",
)
elif item["type"] == "input_image":
# TODO: handle the input image type for the tool input
pass
elif item["type"] == "input_file":
# TODO: handle the input file type for the tool input
pass
elif TYPE_CHECKING:
assert_never(item["type"])


def _get_attributes_from_generation_span_data(
Expand Down
15 changes: 13 additions & 2 deletions ...entation/openinference-instrumentation-openai-agents/tests/test_span_attribute_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,8 @@ def test_get_attributes_from_response_function_tool_call_param(
"output": "",
},
{
"message.content": "",
"message.role": "tool",
"message.content": "",
"message.tool_call_id": "123",
},
id="empty_output",
Expand All @@ -421,12 +421,23 @@ def test_get_attributes_from_response_function_tool_call_param(
"output": None,
},
{
"message.content": None,
"message.role": "tool",
"message.tool_call_id": "123",
},
id="none_output",
),
pytest.param(
{
"call_id": "123",
"output": [{"type": "input_text", "text": "result"}],
},
{
"message.role": "tool",
"message.contents.0.message_content.text": "result",
"message.tool_call_id": "123",
},
id="functional_call_output",
),
],
)
def test_get_attributes_from_function_call_output(
Expand Down