Skip to content

Commit

Permalink
fix: failed imports from typing_extensions 4.5.0 in Colab (#1620)
Browse files Browse the repository at this point in the history
* fix imports for typing_extensions 4.5.0

* put version ceiling on typing_extensions for CI
  • Loading branch information
RogerHYang authored Oct 13, 2023
1 parent c092387 commit f57c4bb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ dependencies = [
"requests",
"protobuf==3.20", # version minimum (for tests)
"responses",
"tiktoken"
"tiktoken",
"typing-extensions<4.6.0", # for Colab
]

[tool.hatch.envs.type]
Expand Down
4 changes: 1 addition & 3 deletions src/phoenix/utilities/error_handling.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import logging
import traceback
from typing import Any, Callable, Iterable, Optional, Type

from typing_extensions import TypeVar, cast
from typing import Any, Callable, Iterable, Optional, Type, TypeVar, cast

F = TypeVar("F", bound=Callable[..., Any])

Expand Down

0 comments on commit f57c4bb

Please sign in to comment.