Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompts!): prompt template management #5724

Draft
wants to merge 102 commits into
base: main
Choose a base branch
from
Draft

feat(prompts!): prompt template management #5724

wants to merge 102 commits into from

Conversation

mikeldking
Copy link
Contributor

resolves #5582

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 12, 2024
@mikeldking mikeldking marked this pull request as draft December 12, 2024 22:10
@mikeldking mikeldking added the feature branch a feature branch that consolidates multiple features into a single commit on main label Dec 12, 2024
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking feature branch

@mikeldking mikeldking force-pushed the prompts branch 4 times, most recently from 6da6bdc to 3c3c5e0 Compare December 28, 2024 07:57
@mikeldking mikeldking force-pushed the prompts branch 2 times, most recently from b34c106 to 4973813 Compare January 9, 2025 20:06
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mikeldking and others added 18 commits January 24, 2025 15:09
* wip

* WIP

* WIP

* add the prompt type

* add initial listing

* feat: temporary prompt

* final changes

* add aria role
…rompt specific playground (#5748)

* feat(prompts): Add prompt selection combobox to playground instances

* Implement prompt/:id/playground route and add link from prompt page

* Rename prompt combobox components for clarity
* feat(prompts): Implement SavePromptForm for creating new prompts

* Rename button to 'save'
* Add prompt table migrations

* Fix typo

* Update migration test

* Address migration feedback

* Use default names for constraints

* Add source prompt id
* cleanup

* feat(prompts): rudimentary prompt details page #5741

* Update app/src/pages/prompt/PromptTabContent.tsx

Co-authored-by: Anthony Powell <apowell@arize.com>

---------

Co-authored-by: Anthony Powell <apowell@arize.com>
* Add PromptVersion query

* Update src/phoenix/server/api/types/PromptVersion.py

* reorganize

* cleanup

* Update the schema

---------

Co-authored-by: Mikyo King <mikyo@arize.com>
* refactor(prompts): URL based routing and loader sharing for prompts

- /prompts/:prompId has been converted to a layout component
- sub-routes of promptId share loader data with promptLoader
- prompt detail page tabs perform navigations

* feat(prompts): Add query fragment to prompt versions sub-route

* feat(prompts): Implement routing, loaders, and fragments for prompt version list

* Add PromptVersion to node query

* fix imports

* Ensure all unset fields are set

* fix comma

* Distinguish prompt version details from one another

* Move truncate component

* Consolidate prompt tab nav logic

---------

Co-authored-by: Dustin Ngo <dustin@arize.com>
…5780)

* feat(prompts): Render model invocation params in propt details view

* Use fragment in PromptInvocationParameters

* temporarily use component styles for lists until we can migrate

* fix scrolling

---------

Co-authored-by: Mikyo King <mikyo@arize.com>
* feat(prompts): Render prompt messages on prompt detail view

* Remove unused import

* Implement copy and paste button on prompt chat messages

* Render chat messages on prompt version details page

* Redirect to latest version when clicking versions tab

Additionally highlight active version in versions list

* Update example data to match template language

* Fix prompt details page width, prompt versions borders / scroll

* Distinguish readOnly TemplateEditor styling from normal TemplateEditor

* Refactor active prompt id into prop

* Replace custom button with styled anchor

* Rename node in promptVersion query
* Flesh out PromptVersionTemplate type

* Return GraphQL objects with the correct type

* Use new types in node query

* Decouple pydantic models and gql types

* Rebuild gql schema

* Rework model names

* Update gql schema

* Propagate name into schema

* Incorporate feedback

* Update schema

* adjust UI to new schema

* cleanup

* Remove `hub` naming and clean up type annotations

---------

Co-authored-by: Mikyo King <mikyo@arize.com>
* chore: fix lint errors

* cleanup

* cleanup
* feat(prompts): preview of last 5 versions

* feat(prompts): preview of last 5 versions

* rename
mikeldking and others added 18 commits January 24, 2025 15:09
…ntent prompts (#6084)

* feat(prompts): Save and display playground instances as multi-part content prompts

* Improve commenting

* Rename file

* Fix text normalization inconsistencies, add tests

* Hide chat part disclosures when there is only when text child

* Align tool result id with tool result content

* Improve comments

* More comments
…6091)

This prevents data-loss from re-parenting playground on a new route

Before:

/prompts/1234/playground -> click dataset -> /playground/datasets/9876
Causes remount, data loss

After:

/prompts/1234/playground -> click dataset -> /prompts/1234/playground?datasetId="9876"
No remount, no data loss, just state updates
* fix(components): fix button size and variance props

* remove varianceProps interface
* Add GET /prompts route

* Use proper ORM class
* feat(prompts): Update prompt combobox after save

Also reset dirty state on save

* Block page navigation when any instance is dirty

* Use native beforeunload dialog

* Aggresively re-fetch prompt combobox

This allows the prompt combobox to repopulate when new prompts are created,
but it also causes it to overfetch whenever you change prompts
* feat(prompts): cleanup versions ui

* cleanup

* cleanup styles
* feat(prompts): Display basic LLM details on Prompt Details pages

* Remove extraneous export
* feat: date range picker

* WIP

* cleanp

* time field

* cleanup
…ema for code snippets (#6132)

* feat(prompts): Convert from Prompt message schema to LLM Provider schema for code snippets

* Update prompt code snippet empty state

* Reuse prompt utils in promptToOpenai conversion and back
* Allow tag updates along with version creation

* Build gql schema

* Update relay artifacts
…ia (#6143)

* feat(components): Port RadioGroup from react aria

* Add another radio group story

* Fix width of radio group

* Fix layout issues with RadioGroups inside of overflow

* Replace deprecated usage of arizeai RadioGroup

* Make L radio group variant consistent with old radio group

* Rename RadioGroup dir to Radio

* Implement ToggleButtonGroup

* Convert RadioGroups to ToggleButtonGroups

* Update Radio component styles and stories

* Adjust styles for ToggleButtonGroup and RadioGroup

* Use more css vars
* Add label color and version metadata

* Update gql schema

* Add color column to the right table

* Add metadata to Prompt as well
* Add prompt label node and mutations

* Add PromptLabel to node interface

* Add prompts resolver on PromptLabel node

* Add prompt label mutations mixin and build gql schema

* Add prompt labels query

* Delete needless comment

* Address feedback

* Build gql schema
mikeldking and others added 11 commits January 24, 2025 15:25
* feat(prompts): add open in playground action button on the table

* cleanup
* feat(components): time range form

* Update app/src/components/datetime/TimeRangeForm.tsx

Co-authored-by: Anthony Powell <apowell@arize.com>

* Update app/src/components/datetime/TimeRangeForm.tsx

Co-authored-by: Anthony Powell <apowell@arize.com>

---------

Co-authored-by: Anthony Powell <apowell@arize.com>
* feat(promts): skeleton UI for promts (#5726)

* wip

* WIP

* WIP

* add the prompt type

* add initial listing

* feat: temporary prompt

* final changes

* add aria role

* Build OpenAPI schema

* Use GID, not databse ID

* Build openapi schema

* Refactor to use prompt identifier

* Update OpenAPI schema

* Ruff 🐶

* Update route and openapi schema

* Use new pydantic models

* Restore latest route

* Rebuild schema

* Add warning (we're not handling citation events)

* Temporarily ignore `assert_never`

* Remove react component

* Remove component

* Ruff 🐶

---------

Co-authored-by: Mikyo King <mikyo@arize.com>
… and tag names (#6204)

Rule is relaxed to include underscores.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature branch a feature branch that consolidates multiple features into a single commit on main size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: 🔍. Needs Review
Development

Successfully merging this pull request may close these issues.

🗺 Prompt Management
6 participants