Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prompts): output schema #6194

Merged
merged 15 commits into from
Feb 3, 2025
Merged

fix(prompts): output schema #6194

merged 15 commits into from
Feb 3, 2025

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Jan 29, 2025

Fixes output schema, which was broken. Also enforces that the schema field is valid json schema

resolves #6195

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 29, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to prompts January 29, 2025 05:04
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 29, 2025
@axiomofjoy axiomofjoy force-pushed the xander/output-schema branch from f48c074 to f2ce1a9 Compare January 29, 2025 05:06
@axiomofjoy axiomofjoy force-pushed the xander/output-schema branch from f74cf6e to b5af4b7 Compare February 1, 2025 23:38
@axiomofjoy axiomofjoy force-pushed the xander/output-schema branch from 5e4319c to 4adbfa4 Compare February 2, 2025 04:54
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 2, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 2, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 2, 2025
@axiomofjoy axiomofjoy requested a review from RogerHYang February 3, 2025 07:11
@axiomofjoy axiomofjoy merged commit 51598fc into prompts Feb 3, 2025
53 of 54 checks passed
@axiomofjoy axiomofjoy deleted the xander/output-schema branch February 3, 2025 20:22
mikeldking pushed a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants