Limit CF_OnUpdate rate for perf boost #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CF_OnUpdate loop is fairly expensive especially on server. Limit update rate to 25 ms on server and 5 ms on client. Significant performance boost was observed when many modules are using update loops (e.g. COT gained 10% tick rate increase on server with this change).
Arkensor
reviewed
Mar 3, 2023
… time measurement
Arkensor
requested changes
Mar 9, 2023
|
There was a reason why the defines were in their own file / addon some time. Not sure if this is still needed. Please clarify why it was moved. @Jacob-Mango do you remember why we had it there? |
|
Relevant commit on devel 317f91f |
Sync with origin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CF_OnUpdate loop is fairly expensive especially on server. Limit update rate to 25 ms on server. Significant performance boost was observed when many modules are using update loops (e.g. COT gained 10% tick rate increase on server with this change).