Add ReadAllLines, ReadAllText, and ReadAllBytes to CF_File #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches C# standard
Missed compile errors
Arkensor
reviewed
Jul 21, 2023
Comment on lines
+331
to
+351
| static string ReadAllText(string path) | ||
| { | ||
| CF_File file = new CF_File(path); | ||
| if (!file.IsValid()) | ||
| { | ||
| return string.Empty; | ||
| } | ||
|
|
||
| string fileContents; | ||
| CF_FileStream fileStream = file.CreateStream(FileMode.READ); | ||
| CF_Byte byte = fileStream.Next(); | ||
| while (byte) | ||
| { | ||
| fileContents += byte.AsciiToString(); | ||
| byte = fileStream.Next(); | ||
| } | ||
|
|
||
| fileStream.Close(); | ||
|
|
||
| return fileContents; | ||
| } |
There was a problem hiding this comment.
I think for performance reasons something like this should not be read through the whole file io pipeline with every single character going through multiple script calls? Wouln't FGets be an order of magnitude faster?
What was your use case when you came up with the idea to add these 3 methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.