Added CF_Trace, CF_Log, CF_Date, CF_Localiser #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Arkensor
reviewed
Aug 16, 2021
There was a problem hiding this comment.
Not sure why log levels are implemented as bitmask ... That is rather odd
Also without docs and all the other code from other branches, it is not easy to give feedback. I will only re-review after docs were added so I can understand the core additions of this.
… additional variables if out of bounds
- Documentation
Arkensor
requested changes
Dec 5, 2021
There was a problem hiding this comment.
CF_Date Compare needs some major attention or needs to be scrapped. If the Compare feature was not new and I just noticed in this rename, then it needs work at a later time.
CF_Trace needs better explanations so users understand when and how to use it.
Some minor naming/description suggestions.
Details in the comments.
This was referenced Dec 5, 2021
Open
…or compile issue in other branch
Arkensor
reviewed
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.