feat(mappings): change precedence (FIX #42)

ArnaudBuchholz · Mar 23, 2023 · 7cc8e8a · 7cc8e8a
1 parent 9b7b26e
commit 7cc8e8a
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/reserve.js b/src/reserve.js
@@ -10,6 +10,7 @@ module.exports = job => check({
   port: job.port,
   mappings: [
     cors,
+    ...job.mappings ?? [],
     ...job.serveOnly ? [] : endpoints(job),
     ...ui5(job),
     ...job.serveOnly ? [] : coverage(job), {
@@ -19,7 +20,6 @@ module.exports = job => check({
       strict: true,
       'ignore-if-not-found': true
     },
-    ...job.mappings ?? [],
     ...unhandled(job)
   ]
 })
diff --git a/src/simulate.spec.js b/src/simulate.spec.js
@@ -120,6 +120,35 @@ describe('simulate', () => {
     }
   }
 
+  describe.only('mappings', () => {
+    beforeAll(async () => {
+      await setup('mappings', {
+        mappings: [
+          '/overridden/resources/(.*)=file(./LICENSE)'
+        ]
+      })
+    })
+
+    const urls = [
+      '/webapp/resources/sap-ui-core.js',
+      '/resources/sap-ui-core.js',
+      '/custom/resources/sap-ui-core.js'
+    ]
+    urls.forEach(url => {
+      it(`fetches UI5 resources whichever path is used (${url})`, async () => {
+        const response = await get(url, 'test.html')
+        expect(response.statusCode).toStrictEqual(200)
+        expect(response.toString().includes('/sap-ui-core.js */')).toStrictEqual(true)
+      })
+    })
+
+    it('enables overridding through mappings', async () => {
+      const response = await get('/overridden/resources/sap-ui-core.js', 'test.html')
+      expect(response.statusCode).toStrictEqual(200)
+      expect(response.toString().startsWith('MIT License')).toStrictEqual(true)
+    })
+  })
+
   describe('legacy (local project)', () => {
     describe('simple test execution', () => {
       beforeAll(async () => {