Skip to content

Commit

Permalink
fix: linter fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ArnaudBuchholz committed Feb 6, 2024
1 parent 062f8c6 commit dd5bc8c
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 37 deletions.
4 changes: 2 additions & 2 deletions src/defaults/puppeteer.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ require('./browser')({
}

if (options.basicAuthUsername || options.basicAuthPassword) {
await page.authenticate({'username': options.basicAuthUsername, 'password': options.basicAuthPassword});
await page.authenticate({ username: options.basicAuthUsername, password: options.basicAuthPassword })
}

page
.on('console', message => consoleWriter.append({
type: message.type(),
Expand Down
2 changes: 1 addition & 1 deletion test/auth_sample.js/basic_authent.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ module.exports = (request, response, url) => {
'WWW-Authenticate': 'Basic realm=""'
})
response.end()
}
}
14 changes: 7 additions & 7 deletions test/auth_sample.js/webapp/App.controller.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
sap.ui.define(
["sap/ui/core/mvc/Controller", "sap/m/MessageToast"],
['sap/ui/core/mvc/Controller', 'sap/m/MessageToast'],
function (Controller, MessageToast) {
"use strict";
'use strict'

return Controller.extend("auth.sample.js.App", {
return Controller.extend('auth.sample.js.App', {
onInit: function () {},

onPress: function () {
MessageToast.show("Hello World!");
},
});
MessageToast.show('Hello World!')
}
})
}
);
)
22 changes: 11 additions & 11 deletions test/auth_sample.js/webapp/test/integration/HelloJourney.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
sap.ui.define(["sap/ui/test/opaQunit", "./pages/Main"], function () {
"use strict";
sap.ui.define(['sap/ui/test/opaQunit', './pages/Main'], function () {
'use strict'

QUnit.module("Sample Basic Auth Journey");
QUnit.module('Sample Basic Auth Journey')

opaTest("Should test basic auth", function (Given, When, Then) {
opaTest('Should test basic auth', function (Given, When, Then) {
// Arrangements
Given.iStartMyAppInAFrame({
source: "../../index.html",
});
source: '../../index.html'
})

// Actions
When.onTheMainPage.iPressTheSayHelloButton();
When.onTheMainPage.iPressTheSayHelloButton()

// Assertions
Then.onTheMainPage.iShouldSeeTheHelloDialog();
Then.onTheMainPage.iShouldSeeTheHelloDialog()

// Cleanup
Then.iTeardownMyApp();
});
});
Then.iTeardownMyApp()
})
})
32 changes: 16 additions & 16 deletions test/auth_sample.js/webapp/test/integration/pages/Main.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
sap.ui.define(
["sap/ui/test/Opa5", "sap/ui/test/actions/Press"],
['sap/ui/test/Opa5', 'sap/ui/test/actions/Press'],
function (Opa5, Press) {
"use strict";
'use strict'

Opa5.createPageObjects({
onTheMainPage: {
actions: {
iPressTheSayHelloButton: function () {
return this.waitFor({
id: "button0",
viewName: "auth.sample.js.App",
id: 'button0',
viewName: 'auth.sample.js.App',
actions: new Press(),
errorMessage:
"Did not find the 'Click me!' button on the App view",
});
},
"Did not find the 'Click me!' button on the App view"
})
}
},

assertions: {
Expand All @@ -24,16 +24,16 @@ sap.ui.define(
autoWait: false,
check: function () {
// Locate the message toast using its class name in a jQuery function
return Opa5.getJQuery()(".sapMMessageToast").length > 0;
return Opa5.getJQuery()('.sapMMessageToast').length > 0
},
success: function () {
Opa5.assert.ok(true, "The message toast was shown");
Opa5.assert.ok(true, 'The message toast was shown')
},
errorMessage: "The message toast did not show up",
});
},
},
},
});
errorMessage: 'The message toast did not show up'
})
}
}
}
})
}
);
)

0 comments on commit dd5bc8c

Please sign in to comment.