Skip to content

Added 'unSellLand' to allow users to cancel their NFT sales#1

Open
ariesgun wants to merge 1 commit intoArome8240:masterfrom
ariesgun:master
Open

Added 'unSellLand' to allow users to cancel their NFT sales#1
ariesgun wants to merge 1 commit intoArome8240:masterfrom
ariesgun:master

Conversation

@ariesgun
Copy link

I have a couple of feedbacks:

  1. In the contract, I think it makes sense not to transfer the recently minted token to the marketplace contract directly. After minting the token, the user then can decide to sell it or not.
  2. When a user sells his or her token, the website shows that the user can buy their own token back. CELO tokens will be sent to the marketplace and then back to their wallet. In the PR, I proposed to create a new function "unSellLand" to cancel the sale and transfer the NFT back to the owner.
  3. Small updated in the frontend to allow users to "cancel sale" their NFT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments