[Port] More cool visuals for ballistics #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Administration
|
Don't merge this yet, explosions are scuffed rn and I need to figure out why |
|
Ready for review now |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
RimiNosha
requested changes
Jan 16, 2024
RimiNosha
removed
Stale
RimiNosha
removed
Fix
RimiNosha
approved these changes
Jan 21, 2024
Artea-Station-Bot
added a commit
that referenced
this pull request
Jan 21, 2024
Merged
QuacksQ
added a commit
that referenced
this pull request
Oct 5, 2024
## About The Pull Request This pr is a port of: - Mojave-Sun/mojave-sun-13#430 This PR significantly improves recoil (screenshake when shooting guns) because our current recoil sucks ass. Instead of a simple screenshake its now based on the direction you're shooting in. I have also gone ahead and added recoil values to the guns we have in-game right now. Ballistic guns have a recoil value of `1` Energy guns have a recoil value of `0.2` Disablers and the Miniature energy gun have a recoil value of because they're tiny `0.1` This is yet another expansion of the guns and other cool shit pr's like: #520 #455 and #460. ## How Does This Help ***Gameplay***? Feedback to in game actions is always good and guns not having recoil when being shot is just weird. ## How Does This Help ***Roleplay***? Immersion probably ## Proof of Testing <details> <summary>Screenshots/Videos</summary> <!-- Leave the line after this one empty. Embeds like breaking if you don't --> ## Old Recoil https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/3a483a6d-a98f-4ae7-a34e-f4b7750ac7c1 ## New Recoil https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/6bcefbc4-3070-44f6-90ba-45638c99b553 ## New recoil on a disabler https://github.com/Artea-Station/Artea-Station-Server/assets/79924768/7ac9e71a-eebb-4be8-afc3-a971c3d2d013 </details> ## Changelog :cl: qol: Recoil is alot less awful now and is based on the direction you're shooting in. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Holy shit this is cool as fuck please merge this 🙏
builds on #455 and #460.
This PR adds a buncha cool particle effects for ballistic guns and new explosion visuals because the old ones suck.
Code and everything is originally from TGMC so this is a port of the following PR's:
Code was borrowed from a Mojave Sun PR because I dont know how to code lmao.
This looks so fucking cool combined with the movable physics on the shell casings dude. imagine how cool gunfights on the station are gonna look after this.
How Does This Help Gameplay?
It helps gameplay because it looks cool as fuck just look at it dude.
How Does This Help Roleplay?
More Immersion because it looks alot more realistic? Idk dude sue me at this point I just want cooler gun visuals and this is gonna help my immersion alot :)
Proof of Testing
Screenshots/Videos
New explosions
2024-01-08.00-24-39.mp4
New gun visuals
2024-01-08.00-27-38.mp4
Changelog
🆑
qol: Ballistics now emit smoke when fired and bullet impacts also have proper smoke added to them.
qol: Explosions look much cooler and have many more particles to them!
imageadd: Added a newer and much cooler explosion sprite (grabbed from Mojave Sun)
/:cl: