Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Droning Subsystem #596

Merged
merged 8 commits into from
Oct 5, 2024
Merged

Conversation

QuacksQ
Copy link
Contributor

@QuacksQ QuacksQ commented Jun 9, 2024

About The Pull Request

This PR ports the Droning Subsystem from EFN.

The Droning SS is used for playing looped music for the area's that players are in. Different music can be given to different areas and areas can have multiple different tracks tied to them that will change when a player enters said area. In my opinion this is a super cool Subsystem that we could benefit a lot from because it adds much more atmosphere to the ship when properly setup. (Video previews in proof of testing are a bit short due to github file size limitations)

This Subsystem does not replace the already existing ship ambience, instead it plays at the same time adding to the soundscape of the server in a unique way.

Currently on this PR I have given the different Areas featured on Belryth their own tracks and it is making for a nice and dark atmosphere aboard an old and forgotten ship. All the tracks on the PR currently are simple liminal tracks and
ambient droning. This SS does not come with a pref that players can toggle and I am not intending to add one either.

All tracks have been sourced from: https://freesound.org/ See below for all the tracks that have been used on this PR.

Tracks used:

https://freesound.org/people/ZHR%C3%98/sounds/692011/

https://freesound.org/people/ZHR%C3%98/sounds/531447/

https://freesound.org/people/ZHR%C3%98/sounds/692006/

https://freesound.org/people/ZHR%C3%98/sounds/692009/

https://freesound.org/people/ZHR%C3%98/sounds/702966/

https://freesound.org/people/Mellau/sounds/505667/

https://freesound.org/people/GregorQuendel/sounds/674408/

Code and inspiration taken from Escape from Nevado:

How Does This Help Gameplay?

Background music ontop of the normal sounds + the ambience sound system is so much better. The atmosphere is completely different on the ship now and it feels much darker and drearier.

How Does This Help Roleplay?

Immersion, adding this to our soundscape makes me feel 10x more immersed when im standing in some shitty dark corner on Belryth.

Proof of Testing

Screenshots/Videos

SOUND ON 🔉

2024-06-09.10-36-12.mp4

Normal ship droning

2024-06-09.10-36-40.mp4

Medical Droning

2024-06-09.10-37-15.mp4

Engi Droning

2024-06-09.10-38-03.mp4

Changelog

🆑
soundadd: Added multiple tracks of background music that change depending on the area of the ship you are in.
/:cl:

@github-actions github-actions bot added Feature How I broke the server in one easy step! Port "So I saw this cool thing-" Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches". labels Jun 9, 2024
code/game/area/areas.dm Show resolved Hide resolved
QuacksQ and others added 2 commits June 14, 2024 21:58
Signed-off-by: Rimi Nosha <riminosha@gmail.com>
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jun 22, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Jun 22, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jun 30, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 9, 2024
@github-actions github-actions bot closed this Jul 16, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Jul 18, 2024
@RimiNosha RimiNosha reopened this Jul 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 26, 2024
@github-actions github-actions bot closed this Aug 2, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Aug 3, 2024
@RimiNosha RimiNosha reopened this Aug 3, 2024
@ChungusGamer666
Copy link
Contributor

patiently waiting for droning v2: copyright infringio enabled edition

@QuacksQ QuacksQ merged commit 7d9a36b into Artea-Station:master Oct 5, 2024
45 checks passed
@QuacksQ
Copy link
Contributor Author

QuacksQ commented Oct 5, 2024

Droning V2 coming soon ™️

Artea-Station-Bot added a commit that referenced this pull request Oct 5, 2024
@QuacksQ QuacksQ deleted the droning-ss branch October 5, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature How I broke the server in one easy step! Port "So I saw this cool thing-" Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants