-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PORT] Droning Subsystem #596
Conversation
Signed-off-by: Rimi Nosha <riminosha@gmail.com>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
patiently waiting for droning v2: copyright infringio enabled edition |
Droning V2 coming soon ™️ |
About The Pull Request
This PR ports the Droning Subsystem from EFN.
The Droning SS is used for playing looped music for the area's that players are in. Different music can be given to different areas and areas can have multiple different tracks tied to them that will change when a player enters said area. In my opinion this is a super cool Subsystem that we could benefit a lot from because it adds much more atmosphere to the ship when properly setup. (Video previews in proof of testing are a bit short due to github file size limitations)
This Subsystem does not replace the already existing ship ambience, instead it plays at the same time adding to the soundscape of the server in a unique way.
Currently on this PR I have given the different Areas featured on Belryth their own tracks and it is making for a nice and dark atmosphere aboard an old and forgotten ship. All the tracks on the PR currently are simple liminal tracks and
ambient droning. This SS does not come with a pref that players can toggle and I am not intending to add one either.
All tracks have been sourced from: https://freesound.org/ See below for all the tracks that have been used on this PR.
Tracks used:
https://freesound.org/people/ZHR%C3%98/sounds/692011/
https://freesound.org/people/ZHR%C3%98/sounds/531447/
https://freesound.org/people/ZHR%C3%98/sounds/692006/
https://freesound.org/people/ZHR%C3%98/sounds/692009/
https://freesound.org/people/ZHR%C3%98/sounds/702966/
https://freesound.org/people/Mellau/sounds/505667/
https://freesound.org/people/GregorQuendel/sounds/674408/
Code and inspiration taken from Escape from Nevado:
How Does This Help Gameplay?
Background music ontop of the normal sounds + the ambience sound system is so much better. The atmosphere is completely different on the ship now and it feels much darker and drearier.
How Does This Help Roleplay?
Immersion, adding this to our soundscape makes me feel 10x more immersed when im standing in some shitty dark corner on Belryth.
Proof of Testing
Screenshots/Videos
SOUND ON 🔉
2024-06-09.10-36-12.mp4
Normal ship droning
2024-06-09.10-36-40.mp4
Medical Droning
2024-06-09.10-37-15.mp4
Engi Droning
2024-06-09.10-38-03.mp4
Changelog
🆑
soundadd: Added multiple tracks of background music that change depending on the area of the ship you are in.
/:cl: