[PORT] Gore update #597
[PORT] Gore update #597
Conversation
github-actions
bot
added
Feature
|
Mystery runtime included on the PR |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
Trying to access the splat_overlays list at an invalid index, or somehow it straight up has not been initialized. From looking at the code here, this should not be possible |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
check if the list is initialized with a length check, it trys to access list item 1 but if the list isn't setup it will fail. |
|
This is going on ice while I work on another project that might kill this |
About The Pull Request
This pr is a port of the following:
This PR will add movable physics to blood droplets and overall increase the mess you make when you're going to town on your fellow crew members. Blood will now shoot from people when they're hit and it will get all over the place which looks pretty cool in my opinion. This pr builds on #455. Blood now also darkens when it dries out!
How Does This Help Gameplay?
More blood and gore as visual clutter when people are being harmed is only fitting, especially on a shithole of a ship like Belryth.
How Does This Help Roleplay?
Immersion? Also its just cool.
Proof of Testing
Screenshots/Videos
2024-06-15.17-38-10.mp4
Changelog
🆑
add: Blood particle effect using movable physics when spessmen are being harmed.
add: Blood squirts using movable physics.
add: Limb dismemberment uses movable physics now.
/:cl: