Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belryth Tweaks and other changes #601

Merged

Conversation

QuacksQ
Copy link
Contributor

@QuacksQ QuacksQ commented Jun 22, 2024

About The Pull Request

PR with Tweaks on Belryth and some other changes that I felt like doing. See changelog for complete summary of everything I did. The bulk of the changes is things I forgot and styling Engi to better match our custom sprites.

Changes include:

  • T-comms relay on bottom Z (Toally didn't forget this one)
  • Lights in maints on the bottom Z of Belryth.
  • New Subtype of the warning stripe that fits better.
  • Changes to Wall paint for Engi
  • Changes to Bulkhead paint for Engi
  • New bulkhead subtype for the CE office (Similar will be coming to the other heads soon ™️)
  • Cockroach removal from the trash spawners in maints (Too many roaches on the ship opening doors constantly)
  • Removed some Holomaps on akward spots.
  • Fixed Janitor shutters not having an access requirement.

How Does This Help Gameplay?

Better mapping is always cool and nicer visuals are cool too.

How Does This Help Roleplay?

Immersion? 🤷

Proof of Testing

Screenshots/Videos

Engi changes

Before

image

image

After

image

image

Changelog

🆑
add: Added T-comms relay on bottom Z for engi
add: Added lights in maints on bottom Z of Belryth.
add: Added a new Subtype of the command airlock for the CE.
imageadd: Added a new subtype of the warning stripes for engi areas
code: Changed the wallpaint and airlock paint for engi to fit in better with the sprites made by Crumpaloo.
code: Did some minor mapping touch-ups around Belryth in general.
qol: Added Shutters for Botany
del: Removed some Holomaps on walls in akward spots
del: Removed Cockroaches from trash spawners.
fix: Fixed Janitor shutters not having an access requirement on Belryth.
/:cl:

@github-actions github-actions bot added Feature How I broke the server in one easy step! Mapping Something something someone placed three reinforced window spawners in one place. Quality of Life Also known as "I deleted a ton of other things and made one particular thing the only way". Removal "What is soul? Are you a cult?" Sprites I like pretty things. labels Jun 22, 2024
@github-actions github-actions bot added the Fix Cleans up someone else's code from 5 years ago. label Jun 22, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 6, 2024
@github-actions github-actions bot closed this Jul 13, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Jul 18, 2024
@RimiNosha RimiNosha reopened this Jul 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 26, 2024
@github-actions github-actions bot closed this Aug 2, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Aug 3, 2024
@RimiNosha RimiNosha reopened this Aug 3, 2024
@RimiNosha RimiNosha merged commit 907023c into Artea-Station:master Aug 25, 2024
33 of 34 checks passed
Artea-Station-Bot added a commit that referenced this pull request Aug 25, 2024
@QuacksQ QuacksQ deleted the turd-polishing(Belryth-touchups) branch October 5, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature How I broke the server in one easy step! Fix Cleans up someone else's code from 5 years ago. Mapping Something something someone placed three reinforced window spawners in one place. Quality of Life Also known as "I deleted a ton of other things and made one particular thing the only way". Removal "What is soul? Are you a cult?" Sprites I like pretty things.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants