Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semi random changes PR + #610 follow-up #611

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Semi random changes PR + #610 follow-up #611

wants to merge 9 commits into from

Conversation

QuacksQ
Copy link
Contributor

@QuacksQ QuacksQ commented Oct 6, 2024 •
edited
Loading

About The Pull Request

This PR has a bunch of random changes because I didn't feel like spamming smaller PR's for whats being done.
Changes include:

  • Color changes for the light produced by flashlights/hardhats/hardsuits.
  • Minor mapping changes on Belryth
  • Banana peel removal from trash spawners (I'm sick and tired of 100's of banana peels on the map)
  • Security department drippening (they get cool colors now and "new" uniforms)

also a follow up of #610

How Does This Help Gameplay?

Tiny changes, minimal impact on gameplay for the most part.

How Does This Help Roleplay?

More immersion? Dude sue me I dont know how to justify this but it needs to happen.

Proof of Testing

Screenshots/Videos

Coming soon ™️

Changelog

🆑
fix: Minor mapping changes on Belryth
/:cl:

@github-actions github-actions bot added Administration Someone messed with admin tools. Balance Also known as "I died to this, let's make it bad". Config Update Oh boy, Rimi has to touch the server config when this gets merged. Feature How I broke the server in one easy step! Fix Cleans up someone else's code from 5 years ago. Grammar and Formatting Not all of us have formal education in english. Mapping Something something someone placed three reinforced window spawners in one place. Quality of Life Also known as "I deleted a ton of other things and made one particular thing the only way". Refactor Also known as "I added a ton of new code that no one will ever use, while failing CI randomly". Removal "What is soul? Are you a cult?" Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches". Sprites I like pretty things. labels Oct 6, 2024
@QuacksQ QuacksQ removed Quality of Life Also known as "I deleted a ton of other things and made one particular thing the only way". Refactor Also known as "I added a ton of new code that no one will ever use, while failing CI randomly". Sounds Also known as "I added a background rumble to lavaland and gave everyone headaches". Balance Also known as "I died to this, let's make it bad". Config Update Oh boy, Rimi has to touch the server config when this gets merged. Feature How I broke the server in one easy step! Grammar and Formatting Not all of us have formal education in english. Administration Someone messed with admin tools. labels Oct 6, 2024
RimiNosha
RimiNosha requested changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@RimiNosha RimiNosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

code/game/objects/effects/spawners/random/trash.dm Show resolved Hide resolved
code/game/objects/items/devices/flashlight.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RimiNosha RimiNosha RimiNosha requested changes

Assignees
No one assigned
Labels
Fix Cleans up someone else's code from 5 years ago. Mapping Something something someone placed three reinforced window spawners in one place. Removal "What is soul? Are you a cult?" Sprites I like pretty things.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuacksQ @RimiNosha