Release 0.11.2 #207
Merged
Release 0.11.2 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contents of the csv files from Dinoloket changed. There are no _0.csv and _1.csv versions anymore. The .csv files now contain kommas where there used to be empty rules (in the _1.csv files) and quatation marks where added to the files. Hereby my proposed changes
reformatted with black (isort was not necessary)
I encountered another issue, some files have the following line where there is supposed to be metadata: "Van deze put zijn geen standen opgenomen in de DINO-database",,,,,,,,,,,, after which there is no data in the file My approach is maybe not the most ellegant, but it does work
- improve naming of resulting plots
- improve naming of resulting plots
FutureWarning: 'H' is deprecated and will be removed in a future version. Please use 'h' instead of 'H'.
s = start - pd.Timedelta(1, unit="H")
address figure filename in `series_per_group` #199
This reverts commit 3e0460d.
Update dino.py to changes in dinolokets .csv files
|
Read the docs finally accepted my kernel 🙌 After a review this can be merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new Dino format and update KNMI